1078668 - link-clicker calls using dev-server don't work

Status: RESOLVED WORKSFORME

(Hello (Loop) :: Server, defect, P1)

Description

[Dan Mosedale (:dmosedale, :dmose)]

Setting loop.server to https://loop-dev.stage.mozaws.net and then sharing a link, fails to connect a call.

The shared link loads the "start call" page as usual, albeit there are a few interesting warnings in the browser console:

TypeError: loop.config.fxosApp is undefined config.js:7
13:01:54.433 Security wrapper denied access to property length on privileged Javascript object. Support for exposing privileged objects to untrusted content via __exposedProps__ is being gradually removed - use WebIDL bindings or Components.utils.cloneInto instead. Note that only the first denied property access from a given global object will be reported.

Clicking start shows "Connecting..." for a short while (10 secs?), then switches to call failed.

The link generator browser never sees any visible evidence of an incoming call.

Standard8 was looking at something that made him think that the latest server bits were somehow not triggering the necessary push notifications.

It's certainly the case that running 

env LOOP_SERVER=/Users/dmose/r/loop-server mach marionette-test browser/components/loop/test/functional/manifest.ini 

with a copy of the latest server in the pointed to directory fails.

Comment 1

[Rémy Hubscher (:natim)]

The way we handle SimplePushURLs changed with this version, make sure that you've made a POST /registration with this token since you've changed the server.

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

I'm confused.  Shouldn't such a post happen at every browser startup?  If not, how do I force it?

Comment 3

[Mark Banner (:standard8)]

(In reply to Rémy Hubscher (:natim) from comment #1)
> The way we handle SimplePushURLs changed with this version, make sure that
> you've made a POST /registration with this token since you've changed the
> server.

We are doing the same POST /registration that we always have, with just using simplePushURL as the parameter. According to the docs, this is still supported:

https://wiki.mozilla.org/Loop/Architecture/Rooms#Loop_Server_API_Changes

I haven't looked at what changes have been made to the server, so this may be irrelevant.

I have verified the clients work with 0.12.4, but not with latest master.

Comment 4

[Alexis Metaireau (:alexis)]

Okay, we're looking at it.

Comment 5

[James Bonacci [:jbonacci]]

We should check Stage as well...

Comment 6

[Rémy Hubscher (:natim)]

I am pretty sure 0.12.6 has got this bug as well.

Comment 7

[Rémy Hubscher (:natim)]

Never mind, the loadtest tests it: https://github.com/mozilla-services/loop-server/blob/0.12.x/loadtests/loadtest.py#L293

Comment 8

[Alexis Metaireau (:alexis)]

I don't think this problem still exists, but if it's the case, I'm not 100% sure to undestand what it is.

Can you confirm that when you're doing a call from Bob to Alice using the link-clicker UI, Bob's client isn't waken up via simple push?

Comment 9

[Rémy Hubscher (:natim)]

This are the related commits that make me think it has been fixed:

 - https://github.com/mozilla-services/loop-server/commit/3a367ea39dc92bf7bd933a4fd610ce76afabc3c9
 - https://github.com/mozilla-services/loop-server/commit/474111afc879e59ae4056b4af30c6560d6bc8481

Comment 10

[Alexis Metaireau (:alexis)]

And of course, it's wrong. Let me do it again:

Can you confirm that when you're doing a call from Bob to Alice using the link-clicker UI, Alice's client isn't waken up via simple push?

Comment 11

[Mark Banner (:standard8)]

I've just been trying this on dev and its working fine. I've done a combination of direct calls and link clicker calls both ways.