1078754 - Popping out Loop video doesn't resize window correctly (self-view partly hidden)

Status: RESOLVED WORKSFORME

(Hello (Loop) :: Client, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mozilla/5.0 (X11; Linux x86_64; rv:34.0) Gecko/20100101 Firefox/34.0 ID:20141001004005 CSet: c20912812877

When you get and accept a loop call, you will have a small window with the video on the lower right side. Trying to maximizing (popping-out?) it, the size is not perfectly chosen, so that the self-view is visible partly and scrollbars exist.

It would be good if the full video and self-view is shown when the video gets maximized.

Comment 1

[Liz Henry (:lizzard) (relman/hg->git project)]

I just ran into a variant of this problem. "Maximizing" with the diagonal arrow in the title bar resulted in a slightly bigger popup window that had white space for half of the window. This was on today's Aurora, 34.0a2 (2014-10-07).  Attaching a screenshot.

Comment 2

[Liz Henry (:lizzard) (relman/hg->git project)]

Attachment: Screenshot of Loop popup window resize problem with whitespace.

Comment 3

[:shell escalante]

it was resolved enough along the way.  please validate.

Comment 4

[u279076]

Henrik/Liz, could you please confirm this is no longer an issue?

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Attachment: loop-34b7-whitespace.png

White space under the video area when the window is popped out/maximized.

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

I'm still seeing the issue in 34.0b7 on MacOSX 10.8.5 (see attachment above)

Comment 7

[Maire Reavy [:mreavy]]

Liz -- Can you try this on Nightly and Aurora?

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

It looks great in Nightly with e10s on and off, either way. 
In Aurora 35, it's still broken.

Comment 9

[Maire Reavy [:mreavy]]

Liz, can you retest with the most recent Aurora (built last night)?  We uplifted a few bug fixes yesterday, and I believe one of them fixed this bug.  

I think it's too late to try to land this fix on Fx34 (since we have less than 2 weeks to release).  So if it works on Fx35 with the latest uplifts, I suggest we mark this Resolved/WorksForMe.

Thanks!

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

Maire, no problem. Looks great in last night's Aurora: 35.0a2 (2014-11-11)

I'm fine with it not uplifting to 34. It doesn't break any functionality. It just looks a bit clunky!

Comment 11

[Maire Reavy [:mreavy]]

Thanks, Liz.  Based on this information, I'm going to mark this WorksForMe.