1079130 - Modify AppWindowManager to appWindowManager in Gecko

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[(Inactive after June) George Duan [:gduan] [:喬智]]

Follow-up of bug 1049439,
we should modify AppWindowManager to appWindowManager.

Comment 1

[(Inactive after June) George Duan [:gduan] [:喬智]]

mozilla-central/testing/marionette/client/marionette/marionette_test.py
mozilla-central/testing/web-platform/harness/wptrunner/browsers/b2g.py

Comment 2

[(Inactive after June) George Duan [:gduan] [:喬智]]

push to try,
https://tbpl.mozilla.org/?tree=Try&rev=bb1a7eb621db

Comment 3

[(Inactive after June) George Duan [:gduan] [:喬智]]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=fc22264caf97

Comment 4

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: bug1079130.patch

Comment 5

[(Inactive after June) George Duan [:gduan] [:喬智]]

Hi Jonathan,

We plan to make AppWindowManager instantiable in gaia(see bug 1049439), so we might also need to modify part of gecko's code. 

could you review my gecko patch? And please let me know if anything missing. Thanks.

Comment 6

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8501579 [details] [diff] [review]
bug1079130.patch

Review of attachment 8501579 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 7

[Jonathan Griffin (:jgriffin)]

This change might impact some cert suite code, so including some others as an FYI.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/b2g-inbound/rev/3e4dfbe6e871

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3e4dfbe6e871