Closed Bug 1079220 Opened 6 years ago Closed 6 years ago
Modify file structure of Instantbird to match toolkit changes
+++ This bug was initially created as a clone of Bug #1074002, Bug #1074006 +++ Port of bug 1047584 for Thunderbird Maybe also bug 1074011
This patch is pretty broken since when I ported the changes over...well, let's just say our nsMain is pretty different from nsMail. Variables, etc. don't exist so the code doesn't actually compile.
Here is my attempt at fixing attachment 8501032 [details] [diff] [review]. The application.ini stuff (especially around makefiles and crash report URL) isn't figured out yet.
Attachment #8501032 - Attachment is obsolete: true
Comment on attachment 8501009 [details] [diff] [review] Change app structure WIP Review of attachment 8501009 [details] [diff] [review]: ----------------------------------------------------------------- Fix the purplexpcom stuff, and the rest works. ::: im/installer/package-manifest.in @@ +265,2 @@ > @BINPATH@/components/@DLL_PREFIX@purplexpcom@DLL_SUFFIX@ > +#endif Please revert this change completely: @BINPATH@/components/... is OK for Mac.
Attachment #8501009 - Flags: review+
This makes nsMain compile and work. It replaces attachment 8504006 [details] [diff] [review], and needs to be applied after clokep's attachment 8501032 [details] [diff] [review]. I'm attaching this mostly because it can be seen as an interdiff of the changes I did. Really what I did is make our nsMain.cpp match nsMailApp.cpp, except for the things that had a reason to be different.
Attachment #8504006 - Attachment is obsolete: true
This is a patch we should actually check-in (ie. not an interdiff) if you r+ it. With these changes, nsMain and nsMailApp are very close.
Not the most beautiful hack ever, but I think that will do.
Attachment #8504349 - Flags: review?(clokep)
Attachment #8504349 - Flags: review?(clokep) → review+
Attachment #8504331 - Flags: review?(clokep) → review+
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.6
Linux bustage fix: https://hg.mozilla.org/comm-central/rev/a0b9e4da8ee2
Follow-up to match Thunderbird: https://hg.mozilla.org/comm-central/rev/42c2ad43b52d (Ports https://hg.mozilla.org/comm-central/rev/cb0d7be5a15c)
You need to log in before you can comment on or make changes to this bug.