1079231 - Use templated CallNonGenericMethod whenever possible

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine, defect)

Description

[Benjamin Bouvier [:bbouvier] (inactive)]

There are several places where we know at compile time what are the arguments for CallNonGenericMethod, but we still pass them as (non-template) runtime parameters. Not sure it really matters, but that looks good for consistency.

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Use templated CallNonGenericMethod whenever possible

That's all the places I could find with DXR.

Comment 2

[Jason Orendorff [:jorendorff]]

Comment on attachment 8501031 [details] [diff] [review]
Use templated CallNonGenericMethod whenever possible

Review of attachment 8501031 [details] [diff] [review]:
-----------------------------------------------------------------

All right.

Comment 3

[Benjamin Bouvier [:bbouvier] (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b8b6fa54fc1a

Comment 4

[Jeff Walden [:Waldo]]

The SharedTypedArrayObject hit is probably going to make b2g-ics burn, for what it's worth.  The templated form forces interpretation of the parameters as constants, and gcc < 4.6 manages to bust itself using template-dependent functions as constants somehow.  (The right fix is to add %SharedTypedArray% paralleling %TypedArray%, but that was a bridge much further than I wanted to go just to get %TypedArray% landed.)

Comment 5

[Benjamin Bouvier [:bbouvier] (inactive)]

Backed out for build failures on b2g-emulator. I was just submitting this patch as i was reading along the code, but this isn't really needed and won't provide obvious speedups, so i propose to just forget about all of this, unless somebody is willing to fight these silly issues.

https://hg.mozilla.org/integration/mozilla-inbound/rev/62491e20145f

Comment 6

[Benjamin Bouvier [:bbouvier] (inactive)]

(In reply to Jeff Walden [:Waldo] (remove +bmo to email) from comment #4)
> The SharedTypedArrayObject hit is probably going to make b2g-ics burn, for
> what it's worth.  The templated form forces interpretation of the parameters
> as constants, and gcc < 4.6 manages to bust itself using template-dependent
> functions as constants somehow.  (The right fix is to add %SharedTypedArray%
> paralleling %TypedArray%, but that was a bridge much further than I wanted
> to go just to get %TypedArray% landed.)

Fun, the first errors that got triggered actually were in the RegExp files...