1079245 - about:privatebrowsing isn't loaded remote

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Jim Mathies [:jimm]]

1) open the browser in pbm with e10s enabled

result: afaict, about:privatebrowsing is loaded locally.

Comment 1

[Steven MacLeod [:smacleod]]

Attachment: MozReview Request: bz://1079245/smacleod

/r/3623 - Bug 1079245 - Set about:privatebrowsing to load in child. r=mossop

Pull down this commit:

hg pull review -r 8679f0d79ea112fc4d957e51a6a8a38559f5a623

Comment 2

[Dave Townsend [:mossop]]

https://reviewboard.mozilla.org/r/3623/#review2971

Looks good. Do we have tests for this functionality already in the tree somewhere?

Comment 3

[Steven MacLeod [:smacleod]]

https://reviewboard.mozilla.org/r/3623/#review2999

I don't believe so, at least not that I could find.

Comment 4

[Dave Townsend [:mossop]]

Comment on attachment 8561603 [details]
MozReview Request: bz://1079245/smacleod

Per reviewboard let's get a test added here.

Comment 5

[Steven MacLeod [:smacleod]]

Comment on attachment 8561603 [details]
MozReview Request: bz://1079245/smacleod

Test in Bug 1142240 passes before and after this change.

Comment 6

[Dave Townsend [:mossop]]

Comment on attachment 8561603 [details]
MozReview Request: bz://1079245/smacleod

https://reviewboard.mozilla.org/r/3621/#review4255

Ship It!

Comment 7

[Steven MacLeod [:smacleod]]

Comment on attachment 8561603 [details]
MozReview Request: bz://1079245/smacleod

/r/3623 - Bug 1079245 - Set about:privatebrowsing to load in child. r=mossop

Pull down this commit:

hg pull review -r 6531341f50b22956f0828c554a4f0d4a33bf6b91

Comment 8

[Steven MacLeod [:smacleod]]

https://reviewboard.mozilla.org/r/3621/#review4615

Dave, a try push indicated a few test breakages when switching to remote. It appears they were just problems with the test themselves, so I've updated them. The main part of the patch is unchanged.

Comment 9

[Dave Townsend [:mossop]]

Comment on attachment 8561603 [details]
MozReview Request: bz://1079245/smacleod

https://reviewboard.mozilla.org/r/3621/#review4625

Ship It!

Comment 10

[Steven MacLeod [:smacleod]]

https://hg.mozilla.org/integration/fx-team/rev/1b23439451a8

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out (next to bug 1142240) in https://hg.mozilla.org/integration/fx-team/rev/7b259d8a61a8 for being the likely cause of some new intermittent privatebrowsing test failures:

https://treeherder.mozilla.org/logviewer.html#?job_id=2327926&repo=fx-team

Comment 12

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Not sure this needs to be M6. It would be nice to have it, but I don't think it should block.

Comment 13

[Steven MacLeod [:smacleod]]

I'm not going to be finishing up this work. Whoever picks this up needs to look into the test failures and probably update a few tests to handle about:privatebrowsing being remote.

Something that might be worth doing first though is just landing my modifications to about:privatebrowsing without actually flipping it remote so that those changes don't bit rot. Once the tests are fixed making it remote would just requiring adding the flag to AboutRedirector.cpp

Comment 14

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-1079245-Set-about-privatebrowsing-to-load-in-chi.patch

Rebased and pushed to try again:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=afbb5e769063

Comment 15

[Marco Mucci [:MarcoM]]

Hi Felipe, want to confirm if you are taking this bug for IT 40.2?

Comment 16

[Tim Taubert [:ttaubert] (inactive)]

BTW, looks like there isn't much to do here. Try is quite green so far and we could probably just land it. I'll do that once all runs finish and there still are no failures.

Comment 17

[Tim Taubert [:ttaubert] (inactive)]

Try run was all green:

https://hg.mozilla.org/integration/fx-team/rev/6be3314c79db

Should fix and land bug 1142240 next.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6be3314c79db

Comment 20

[Steven MacLeod [:smacleod]]

Attachment: MozReview Request: Bug 1079245 - Set about:privatebrowsing to load in child. r=mossop