Closed Bug 1079245 Opened 7 years ago Closed 6 years ago
about:privatebrowsing isn't loaded remote
9.49 KB, patch
|Details | Diff | Splinter Review|
39 bytes, text/x-review-board-request
1) open the browser in pbm with e10s enabled result: afaict, about:privatebrowsing is loaded locally.
Assignee: nobody → smacleod
Status: NEW → ASSIGNED
Iteration: --- → 38.2 - 9 Feb
/r/3623 - Bug 1079245 - Set about:privatebrowsing to load in child. r=mossop Pull down this commit: hg pull review -r 8679f0d79ea112fc4d957e51a6a8a38559f5a623
Attachment #8561603 - Flags: review?(dtownsend)
https://reviewboard.mozilla.org/r/3623/#review2971 Looks good. Do we have tests for this functionality already in the tree somewhere?
https://reviewboard.mozilla.org/r/3623/#review2999 I don't believe so, at least not that I could find.
Comment on attachment 8561603 [details] MozReview Request: bz://1079245/smacleod Per reviewboard let's get a test added here.
Attachment #8561603 - Flags: review?(dtownsend) → review-
Comment on attachment 8561603 [details] MozReview Request: bz://1079245/smacleod Test in Bug 1142240 passes before and after this change.
Attachment #8561603 - Flags: review- → review?(dtownsend)
Comment on attachment 8561603 [details] MozReview Request: bz://1079245/smacleod https://reviewboard.mozilla.org/r/3621/#review4255 Ship It!
Comment on attachment 8561603 [details] MozReview Request: bz://1079245/smacleod /r/3623 - Bug 1079245 - Set about:privatebrowsing to load in child. r=mossop Pull down this commit: hg pull review -r 6531341f50b22956f0828c554a4f0d4a33bf6b91
Attachment #8561603 - Flags: review+ → review?(dtownsend)
https://reviewboard.mozilla.org/r/3621/#review4615 Dave, a try push indicated a few test breakages when switching to remote. It appears they were just problems with the test themselves, so I've updated them. The main part of the patch is unchanged.
Comment on attachment 8561603 [details] MozReview Request: bz://1079245/smacleod https://reviewboard.mozilla.org/r/3621/#review4625 Ship It!
Backed out (next to bug 1142240) in https://hg.mozilla.org/integration/fx-team/rev/7b259d8a61a8 for being the likely cause of some new intermittent privatebrowsing test failures: https://treeherder.mozilla.org/logviewer.html#?job_id=2327926&repo=fx-team
Not sure this needs to be M6. It would be nice to have it, but I don't think it should block.
I'm not going to be finishing up this work. Whoever picks this up needs to look into the test failures and probably update a few tests to handle about:privatebrowsing being remote. Something that might be worth doing first though is just landing my modifications to about:privatebrowsing without actually flipping it remote so that those changes don't bit rot. Once the tests are fixed making it remote would just requiring adding the flag to AboutRedirector.cpp
Assignee: smacleod → nobody
Status: ASSIGNED → NEW
Rebased and pushed to try again: https://treeherder.mozilla.org/#/jobs?repo=try&revision=afbb5e769063
Hi Felipe, want to confirm if you are taking this bug for IT 40.2?
BTW, looks like there isn't much to do here. Try is quite green so far and we could probably just land it. I'll do that once all runs finish and there still are no failures.
Try run was all green: https://hg.mozilla.org/integration/fx-team/rev/6be3314c79db Should fix and land bug 1142240 next.
You need to log in before you can comment on or make changes to this bug.