Closed Bug 1079255 Opened 7 years ago Closed 7 years ago
[Messages] Flip Settings
.support Email Recipient to true when the functionality is ready
In bug 840515 and its dependencies, we implement the functionality of "send MMS by email", but it's currently pref-ed off until it's finished. In this bug, we want to simply flip this setting to true. We may need to update unit tests that assume the setting is false by default.
feature-b2g:2.2+ for it's to pref on the feature together with bug 997547
setting target milestone to align with bug 997547, which I see has r+'d
Target Milestone: --- → 2.2 S3 (9jan)
Hi Oleg. This bug includes integration tests for the new switching to MMS cases and a new suite case gathering the stuff about showing the conversion banner. Do you mind to review the patch?
Attachment #8546502 - Flags: review?(azasypkin)
Hey Salva, looks and works great so far! I think only bug 1105646 still can annoy user, but it's quite minor. Thanks for the tests. I've added just a few comments at GitHub - in short I'd like that we verify one more simple but important use case in both of your tests. Keeping review flag for now.
Oleg, I addressed the problems we've detected and finished the tests. Could you take a look? Let me know for any problem.
Comment on attachment 8546502 [details] [review] Set flag for enabling MMS to e-mails to true and adding integration tests (In reply to Salvador de la Puente González [:salva] from comment #5) > Oleg, I addressed the problems we've detected and finished the tests. Could > you take a look? Let me know for any problem. Okay, perfect now! Just update PR with the last minor nits we discussed offline and wait for green Treeherder (please re-trigger Gij 2 job several times, 5 or more, to be sure we won't have intermittent failures). Thanks a lot!
Attachment #8546502 - Flags: review?(azasypkin) → review+
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Seems that Treeherder show different errors in unrelated integration tests.
Comment on attachment 8546502 [details] [review] Set flag for enabling MMS to e-mails to true and adding integration tests [Approval Request Comment] [Bug caused by] (feature/regressing bug #): none [User impact] if declined: big; all the functionality of bug 840515 has landed but it's not enabled yet. This bug enables the functionality and add Marionette tests checking the UI of Messages is behaving as expected. [Testing completed]: yes [Risk to taking this patch] (and alternatives if risky): low [String changes made]: none
Attachment #8546502 - Flags: approval-gaia-v2.2?
We have to request the approval because for some strange reason this bug did not land on the v2.2 branch. It seems that the branching left it out for some unknown reason.
Attachment #8546502 - Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
(In reply to Maria Angeles Oteo (:oteo) from comment #10) > We have to request the approval because for some strange reason this bug did > not land on the v2.2 branch. > It seems that the branching left it out for some unknown reason. It landed too late for the branching. No conspiracy theories needed ;) v2.2: https://github.com/mozilla-b2g/gaia/commit/d82524d8e7092afb5dcb587f78e6f13653c6715b
You need to log in before you can comment on or make changes to this bug.