Closed
Bug 1079312
Opened 10 years ago
Closed 10 years ago
AsyncShutdownTimeout "AddonManager: Waiting for providers to shut down.", "OpenH264Provider", crash in mozalloc_abort(char const* const) | NS_DebugBreak | nsDebugImpl::Abort(char const*, int)
Categories
(Toolkit :: Add-ons Manager, defect)
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: Irving, Assigned: gfritzsche)
References
Details
(Keywords: crash, regression)
Crash Data
Attachments
(1 file)
1.37 KB,
patch
|
Irving
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
This bug was filed from the Socorro interface and is report bp-49345111-dcff-470a-bbad-8ba912141004. ============================================================= Exception telemetry is showing {"file":"resource://gre/modules/addons/OpenH264Provider.jsm","message":"TypeError: this._log.warning is not a function","line":274,"context":"provider startup","module" Not sure whether this is causing the shutdown hang or not, but it's close enough to be worth looking at. (spreadsheet of the recent exception telemetry extract at https://docs.google.com/spreadsheets/d/1s_x8tYo8UDq29peO56kgAV5TbB-Sbw59fN26TbJfDv0/edit?usp=sharing)
Assignee | ||
Comment 1•10 years ago
|
||
This is weird - this should be here: http://hg.mozilla.org/mozilla-central/annotate/e4cfacb76830/toolkit/mozapps/extensions/internal/OpenH264Provider.jsm#l274 ... which doesn't use this._log.warning. If this is the exception handler 2 lines down, it's still weird - we initialize this._log a few lines earlier. Are there any known failure scenarios with Log.jsm?
Assignee | ||
Comment 2•10 years ago
|
||
Actually, the this._log.trace() line a little earlier didn't throw, so the logging instance must have broken in the mean-time.
Assignee | ||
Comment 3•10 years ago
|
||
Oh, nevermind - obviously there is a difference between log.warning() and log.warn(). Yikes.
Assignee | ||
Comment 4•10 years ago
|
||
[Tracking Requested - why for this release]: Bug 1070036 was uplifted to fix an issue on systems where OpenH264 activation failed, but introduced a wrong function name for logging. Bug 1074561 was supposed to fix the underlying issue, but the report here was after that bug landed, so this is still an issue. This is after any important initialization of the OpenH264Provider, so still mostly an issue with noise in the addon provider exception telemetry - hence not requesting tracking for 33 and setting wontfix there.
Blocks: 1070036
status-firefox33:
--- → wontfix
status-firefox34:
--- → affected
status-firefox35:
--- → affected
tracking-firefox34:
--- → ?
Keywords: regression
Assignee | ||
Comment 5•10 years ago
|
||
Assignee: nobody → georg.fritzsche
Status: NEW → ASSIGNED
Attachment #8502570 -
Flags: review?(irving)
Updated•10 years ago
|
Reporter | ||
Updated•10 years ago
|
Attachment #8502570 -
Flags: review?(irving) → review+
Assignee | ||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/26841ad4d2eb
Assignee | ||
Comment 7•10 years ago
|
||
Comment on attachment 8502570 [details] [diff] [review] Fix Approval Request Comment [Feature/regressing bug #]: OpenH264 integration. [User impact if declined]: Noise in the addon provider exception telemetry [Describe test coverage new/current, TBPL]: No good coverage with reasonable efforts here. [Risks and why]: Low risk, trivial change / typo-fix. [String/UUID change made/needed]: None.
Attachment #8502570 -
Flags: approval-mozilla-beta?
Attachment #8502570 -
Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/26841ad4d2eb
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Updated•10 years ago
|
status-firefox36:
--- → fixed
Updated•10 years ago
|
Attachment #8502570 -
Flags: approval-mozilla-beta?
Attachment #8502570 -
Flags: approval-mozilla-beta+
Attachment #8502570 -
Flags: approval-mozilla-aurora?
Attachment #8502570 -
Flags: approval-mozilla-aurora+
Comment 9•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/23962a888ef8 https://hg.mozilla.org/releases/mozilla-beta/rev/ae6317e02f72
Updated•10 years ago
|
Flags: qe-verify+
Comment 10•10 years ago
|
||
(In reply to Georg Fritzsche [:gfritzsche] from comment #4) > This is after any important initialization of the OpenH264Provider, so still > mostly an issue with noise in the addon provider exception telemetry - hence > not requesting tracking for 33 and setting wontfix there. Setting as qe-verify-.
Updated•10 years ago
|
Flags: qe-verify+ → qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•