1079327 - [Browser] Website icon image is too big

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Hung Nguyen]

Attachment: screenshot.png

Steps: 

1. Open a new window in browser
2. Have some history present 
3. Observe the history item from "yesterday" 

Actual:
The icon image (grooveshark) is too large compared to the other history items. 

Expected:
The list item should be consistent. 

Screenshot attached.

Comment 1

[Olof Wickström]

Consistency is important for the perceived quality of a device

Comment 3

[Candice Serran (:cserran)]

definitely poor user experience, unexpected functionality

Comment 4

[Marcia Knous [:marcia]]

adding qa wanted to get a better set of STR. Try zooming in on a site and then trying to add it to homescreen.

Comment 5

[Cody Roesch [:croesch]]

STR:
1. Launch Browser from app icon (not rocketbar)
2. Go to websites such as MLB.com, NFL.com, Groove Shark Mobile
3. After the websites load, close out of the browser completely.
4. Relaunch browser app again.
5. Notice the history below has large icons for certain websites.

Most websites I went to with a logo (groove shark mobile, MLB.com, NFL.com) exhibited this problem. History does not need to be from yesterday. Just go to a few websites with prominent logos and then close the browser and reopen it to the Top Sites page. At the bottom is the History with the logo issues being large.

Tested with Shallow Flash on 319mb using Engineering builds

This bug repro's on Flame KK builds: Flame 2.2 KK

Actual Results: Website logos are too large when looking at the browsing history on the Top Sites page.

Repro Rate: 2/2

Environmental Variables:
Device: Flame Master KK
BuildID: 20141015113215
Gaia: 841d0d7d1b879f0ff4b5a8727f5dd23c7b0000a9
Gecko: a280a03c9f3c
Version: 36.0a1 (Master) 
Firmware Version: L1TC10011800
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

-----------------------------------------------------------------
-----------------------------------------------------------------

This bug does NOT repro on Flame kk build: Flame 2.1 KK, flame 2.0 KK

Actual Result: No issue seen with the size of website logos in the browsing history.

Repro Rate: 0/4

Environmental Variables:
Device: Flame 2.1 KK
BuildID: 20141015143144
Gaia: 477a9e61c3edf12f32a62a19d329cd277202cc6b
Gecko: 67573e422a0f
Version: 34.0 (2.1) 
Firmware Version: L1TC10011800
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
-----------------------------------------------------------------
Environmental Variables:
Device: Flame 2.0 KK
BuildID: 20141016063743
Gaia: c6c6116ca225c2c934220ae6867e5a3256d65e00
Gecko: e2ad5b580ebc
Version: 32.0 (2.0) 
Firmware Version: L1TC10011800
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 6

[Joshua Mitchell (Inactive)]

(In reply to Olof Wickström from comment #1)
> Consistency is important for the perceived quality of a device

Olof - you nominated this as a 2.1 blocker but the qa-wanted tester was unable to repro on the 2.1 branch. Can you confirm that this was seen in 2.1?

Hung - same question - did you see this on 2.1? You failed to mention where you saw this issue occur in your original write-up

Comment 7

[Dale Harvey (:daleharvey)]

Ill take a look, it seems like it should occur the same on 2.1

Comment 8

[Dale Harvey (:daleharvey)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/25238

Test is skipped but is passing, needs https://bugzilla.mozilla.org/show_bug.cgi?id=1078739 to finally land, before it passes against master

Comment 9

[Hung Nguyen]

Sorry it was on 2.2. 

I just tried it on 2.1 and I can't reproduce it.

Comment 10

[Joshua Mitchell (Inactive)]

Thank you for verifying - We should move the blocking nom to 2.2 then

Comment 11

[Dale Harvey (:daleharvey)]

This was regressed on https://bugzilla.mozilla.org/show_bug.cgi?id=1074909 which didnt land on 2.1

Comment 12

[Pi Wei Cheng [:piwei] (inactive)]

I can confirm that comment 11 is correct.

b2g-inbound regression window:

Last Working Environmental Variables:
Device: Flame
BuildID: 20141004071230
Gaia: 07ad200c49ff85ca73b3f35211b34df89da00753
Gecko: 8f45a7b868f7
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

First Broken Environmental Variables:
Device:  Flame
BuildID: 20141004082730
Gaia: 6efba330470a888f20f05fc2afd7f7e7978f31e6
Gecko: b617bf656905
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

First Broken Gaia & Last Working Gecko - issue DOES repro
Gaia: 6efba330470a888f20f05fc2afd7f7e7978f31e6
Gecko: 8f45a7b868f7

First Broken Gecko Last Working Gaia - issue does NOT repro
Gaia: 07ad200c49ff85ca73b3f35211b34df89da00753
Gecko: b617bf656905

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/07ad200c49ff85ca73b3f35211b34df89da00753...6efba330470a888f20f05fc2afd7f7e7978f31e6

Caused by Bug 1074909.

Comment 13

[Olof Wickström]

(In reply to Joshua Mitchell [:Joshua_M] from comment #6)
> Olof - you nominated this as a 2.1 blocker but the qa-wanted tester was
> unable to repro on the 2.1 branch. Can you confirm that this was seen in 2.1?

In last UX review we saw an issue on 2.1 which we interpreted as this bug. But as we didn't tested on 2.2 I can't say it is the same issue.
I'll remove the [Tako_Blocker] tag. We'll file a new bug for the other issue if it comes up in next UX review.
Thanks for your help
/Olof

Comment 14

[Ben Francis [:benfrancis]]

Comment on attachment 8506405 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/25238

Looks good to me.

Comment 15

[Ben Francis [:benfrancis]]

There was an integration test failure on treeherder, maybe needs rebasing?

Comment 16

[Dale Harvey (:daleharvey)]

Yeh the integration test couldnt possible be related, this has an integration test but is skipped, will be enabled when I land https://bugzilla.mozilla.org/show_bug.cgi?id=1078739

Comment 17

[Dale Harvey (:daleharvey)]

Landed in https://github.com/mozilla-b2g/gaia/commit/5eaf0745bc39b730fc7f46aebfbc1c1afda2082f

Comment 18

[KTucker [:KTucker][Inactive 3/4/2016]]

Cody, can you please verify that this issue is fixed?

Comment 19

[Gregor Wagner [:gwagner]]

Already in 2.2.

Comment 20

[Cody Roesch [:croesch]]

Tested with Full Flash on 319mb using Engineering builds

This bug no longer repro's on Flame KK builds: Flame 2.2 KK

Actual Results: Website icons are appropriate size in History now.

Repro Rate: 3/3

Environmental Variables:
Device: Flame 2.2 KK
BuildID: 20141020055012
Gaia: dc496d04907dd314f9736ff78bab3bd27156f79a
Gecko: f2d7d694aae5
Version: 36.0a1 (2.2)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Comment 21

[Cody Roesch [:croesch]]

Wrong person NI?'d
Meant to sling it to KTucker