Closed Bug 1079341 Opened 5 years ago Closed 5 years ago

Missing yield on async makeDir in FHR state init

Categories

(Firefox Health Report Graveyard :: Client: Desktop, defect)

defect
Not set

Tracking

(firefox33 wontfix, firefox34 fixed, firefox35 fixed, firefox-esr31 wontfix)

RESOLVED FIXED
Firefox 35
Tracking Status
firefox33 --- wontfix
firefox34 --- fixed
firefox35 --- fixed
firefox-esr31 --- wontfix

People

(Reporter: gfritzsche, Assigned: gfritzsche)

References

Details

Attachments

(1 file)

Attached patch FixSplinter Review
Attachment #8501161 - Flags: review?(gps)
Blocks: 1064333
Comment on attachment 8501161 [details] [diff] [review]
Fix

Review of attachment 8501161 [details] [diff] [review]:
-----------------------------------------------------------------

::: services/healthreport/healthreporter.jsm
@@ +126,5 @@
>      return OS.Path.join(this._stateDir, "lastpayload.json");
>    },
>  
>    init: function () {
>      return Task.spawn(function init() {

While you are here, please turn this into function*.
Attachment #8501161 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/98fade97048a
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Quickly talked to Georg to see if there's anything that QE can do here for verification, marking as qe‑verify-.
Flags: qe-verify-
Comment on attachment 8501161 [details] [diff] [review]
Fix

Approval Request Comment
[Feature/regressing bug #]: Search telemetry. This is a dependency for bug 1064333.
[User impact if declined]:
[Describe test coverage new/current, TBPL]:
[Risks and why]:
See bug 1064333, comment 55.
[String/UUID change made/needed]: None.
Attachment #8501161 - Flags: approval-mozilla-beta?
Attachment #8501161 - Flags: approval-mozilla-aurora?
Comment on attachment 8501161 [details] [diff] [review]
Fix

Not needed on Aurora.
Attachment #8501161 - Flags: approval-mozilla-aurora?
Comment on attachment 8501161 [details] [diff] [review]
Fix

Beta+
Attachment #8501161 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in before you can comment on or make changes to this bug.