Closed
Bug 1079387
Opened 10 years ago
Closed 9 years ago
Intermittent test_bookmarks_html.js | test failed (with xpcshell return code: 0) | 0 == 3
Categories
(Toolkit :: Places, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox35 | --- | fixed |
firefox36 | --- | fixed |
firefox37 | --- | fixed |
firefox-esr31 | --- | unaffected |
People
(Reporter: RyanVM, Assigned: hiro)
References
Details
(Keywords: intermittent-failure)
Attachments
(2 files, 2 obsolete files)
6.32 KB,
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
3.95 KB,
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
https://treeherder.mozilla.org/ui/logviewer.html#?job_id=2822695&repo=mozilla-inbound builder Rev4 MacOSX Snow Leopard 10.6 mozilla-inbound opt test xpcshell buildid 20141007070041 builduid 592a6bc2e4904e5daa59cdce9df4283f results warnings (1) revision b6cf5c560a2f slave t-snow-r4-0087 starttime Tue Oct 07 2014 12:01:22 GMT-0400 (Eastern Standard Time) 09:19:40 INFO - TEST-INFO | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | running test ... 09:19:41 WARNING - TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | test failed (with xpcshell return code: 0), see following log: 09:19:41 INFO - >>>>>>> 09:19:41 INFO - TEST-INFO | (xpcshell/head.js) | test MAIN run_test pending (1) 09:19:41 INFO - TEST-INFO | (xpcshell/head.js) | test run_next_test 0 pending (2) 09:19:41 INFO - TEST-INFO | (xpcshell/head.js) | test MAIN run_test finished (2) 09:19:41 INFO - TEST-INFO | (xpcshell/head.js) | running event loop 09:19:41 INFO - TEST-INFO | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | Starting setup 09:19:41 INFO - TEST-INFO | (xpcshell/head.js) | test setup pending (2) 09:19:41 INFO - TEST-INFO | (xpcshell/head.js) | test run_next_test 0 finished (2) 09:19:41 INFO - TEST-INFO | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | "[testImportedBookmarks()] Checking group 'menu'" 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [testImportedBookmarks : 266] 3 == 3 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 317] "Mozilla Firefox" == "Mozilla Firefox" 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 372] true == true 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 374] 4 == 4 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 317] "Help and Tutorials" == "Help and Tutorials" 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 334] "http://en-us.www.mozilla.com/en-US/firefox/help/" == "http://en-us.www.mozilla.com/en-US/firefox/help/" 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 317] "Customize Firefox" == "Customize Firefox" 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 334] "http://en-us.www.mozilla.com/en-US/firefox/customize/" == "http://en-us.www.mozilla.com/en-US/firefox/customize/" 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 317] "Get Involved" == "Get Involved" 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 334] "http://en-us.www.mozilla.com/en-US/firefox/community/" == "http://en-us.www.mozilla.com/en-US/firefox/community/" 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 317] "About Us" == "About Us" 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 334] "http://en-us.www.mozilla.com/en-US/about/" == "http://en-us.www.mozilla.com/en-US/about/" 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 314] 7 == 7 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 317] "test" == "test" 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 320] "folder test comment" == "folder test comment" 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 325] 1177541020000000 == 1177541020000000 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 329] 1177541050000000 == 1177541050000000 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 372] true == true 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 374] 1 == 1 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 317] "test post keyword" == "test post keyword" 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 320] "item description" == "item description" 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 325] 1177375336000000 == 1177375336000000 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 329] 1177375423000000 == 1177375423000000 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 352] true == true 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 357] "hidden1%3Dbar&text1%3D%25s" == "hidden1%3Dbar&text1%3D%25s" 09:19:41 INFO - TEST-INFO | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | "[testImportedBookmarks()] Checking group 'toolbar'" 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [testImportedBookmarks : 266] 2 == 2 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 317] "Getting Started" == "Getting Started" 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 334] "http://en-us.www.mozilla.com/en-US/firefox/central/" == "http://en-us.www.mozilla.com/en-US/firefox/central/" 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 346] true == true 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 346] true == true 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 346] true == true 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 346] true == true 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 363] "ISO-8859-1" == "ISO-8859-1" 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 346] true == true 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 317] "Latest Headlines" == "Latest Headlines" 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 367] "http://en-us.fxfeeds.mozilla.com/en-US/firefox/livebookmarks/" == "http://en-us.fxfeeds.mozilla.com/en-US/firefox/livebookmarks/" 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 368] "http://en-us.fxfeeds.mozilla.com/en-US/firefox/headlines.xml" == "http://en-us.fxfeeds.mozilla.com/en-US/firefox/headlines.xml" 09:19:41 INFO - TEST-INFO | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | "[testImportedBookmarks()] Checking group 'unfiled'" 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [testImportedBookmarks : 266] 1 == 1 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 317] "Example.tld" == "Example.tld" 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 334] "http://example.tld/" == "http://example.tld/" 09:19:41 INFO - TEST-INFO | (xpcshell/head.js) | test run_next_test 1 pending (2) 09:19:41 INFO - TEST-INFO | (xpcshell/head.js) | test setup finished (2) 09:19:41 INFO - TEST-INFO | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | Starting test_import_new 09:19:41 INFO - TEST-INFO | (xpcshell/head.js) | test test_import_new pending (2) 09:19:41 INFO - TEST-INFO | (xpcshell/head.js) | test run_next_test 1 finished (2) 09:19:41 INFO - TEST-INFO | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | "[testImportedBookmarks()] Checking group 'menu'" 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [testImportedBookmarks : 266] 3 == 3 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 317] "Mozilla Firefox" == "Mozilla Firefox" 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 372] true == true 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 374] 4 == 4 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 317] "Help and Tutorials" == "Help and Tutorials" 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 334] "http://en-us.www.mozilla.com/en-US/firefox/help/" == "http://en-us.www.mozilla.com/en-US/firefox/help/" 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 317] "Customize Firefox" == "Customize Firefox" 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 334] "http://en-us.www.mozilla.com/en-US/firefox/customize/" == "http://en-us.www.mozilla.com/en-US/firefox/customize/" 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 317] "Get Involved" == "Get Involved" 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 334] "http://en-us.www.mozilla.com/en-US/firefox/community/" == "http://en-us.www.mozilla.com/en-US/firefox/community/" 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 317] "About Us" == "About Us" 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 334] "http://en-us.www.mozilla.com/en-US/about/" == "http://en-us.www.mozilla.com/en-US/about/" 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 314] 7 == 7 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 317] "test" == "test" 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 320] "folder test comment" == "folder test comment" 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 325] 1177541020000000 == 1177541020000000 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 329] 1177541050000000 == 1177541050000000 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 372] true == true 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 374] 1 == 1 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 317] "test post keyword" == "test post keyword" 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 320] "item description" == "item description" 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 325] 1177375336000000 == 1177375336000000 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 329] 1177375423000000 == 1177375423000000 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 352] true == true 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 357] "hidden1%3Dbar&text1%3D%25s" == "hidden1%3Dbar&text1%3D%25s" 09:19:41 INFO - TEST-INFO | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | "[testImportedBookmarks()] Checking group 'toolbar'" 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [testImportedBookmarks : 266] 2 == 2 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 317] "Getting Started" == "Getting Started" 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 334] "http://en-us.www.mozilla.com/en-US/firefox/central/" == "http://en-us.www.mozilla.com/en-US/firefox/central/" 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 346] true == true 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 346] true == true 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 346] true == true 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 346] true == true 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 363] "ISO-8859-1" == "ISO-8859-1" 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 346] true == true 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 317] "Latest Headlines" == "Latest Headlines" 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 367] "http://en-us.fxfeeds.mozilla.com/en-US/firefox/livebookmarks/" == "http://en-us.fxfeeds.mozilla.com/en-US/firefox/livebookmarks/" 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 368] "http://en-us.fxfeeds.mozilla.com/en-US/firefox/headlines.xml" == "http://en-us.fxfeeds.mozilla.com/en-US/firefox/headlines.xml" 09:19:41 INFO - TEST-INFO | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | "[testImportedBookmarks()] Checking group 'unfiled'" 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [testImportedBookmarks : 266] 1 == 1 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 317] "Example.tld" == "Example.tld" 09:19:41 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | [checkItem/< : 334] "http://example.tld/" == "http://example.tld/" 09:19:41 INFO - TEST-INFO | (xpcshell/head.js) | test run_next_test 2 pending (2) 09:19:41 INFO - TEST-INFO | (xpcshell/head.js) | test test_import_new finished (2) 09:19:41 INFO - TEST-INFO | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | Starting test_emptytitle_export 09:19:41 INFO - TEST-INFO | (xpcshell/head.js) | test test_emptytitle_export pending (2) 09:19:41 INFO - TEST-INFO | (xpcshell/head.js) | test run_next_test 2 finished (2) 09:19:41 INFO - TEST-INFO | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | "[testImportedBookmarks()] Checking group 'menu'" 09:19:41 WARNING - TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js | 0 == 3 - See following stack: 09:19:41 INFO - /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_bookmarks_html.js:testImportedBookmarks:266 09:19:41 INFO - Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:865:23 09:19:41 INFO - this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:744:7 09:19:41 INFO - _do_main@/builds/slave/talos-slave/test/build/tests/xpcshell/head.js:191:5 09:19:41 INFO - _execute_test@/builds/slave/talos-slave/test/build/tests/xpcshell/head.js:405:5 09:19:41 INFO - @-e:1:1 09:19:41 INFO - TEST-INFO | (xpcshell/head.js) | exiting test 09:19:41 WARNING - TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/tests/xpcshell/head.js | Unexpected exception 2147500036 09:19:41 INFO - TEST-INFO | (xpcshell/head.js) | exiting test 09:19:41 INFO - <<<<<<<
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Reporter | ||
Comment 12•10 years ago
|
||
Oh wait, maybe a regression from bug 1083462?
Flags: needinfo?(ttaubert)
Comment 13•10 years ago
|
||
unlikely a regression due to the kind of change, but it could have made it more likely to hit due to timing changes (some bookmarks operations are now slower)
Flags: needinfo?(mak77)
Updated•10 years ago
|
Points: --- → 3
Flags: qe-verify-
Flags: firefox-backlog+
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment 15•10 years ago
|
||
Looks like test_emptytitle_export() and test_import_ontop() are failing here.
Flags: needinfo?(ttaubert)
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 97•10 years ago
|
||
I am suspecting that lacking yield against checkItem causes this failure. Pushed a try now: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=49e6c7838cc4
Attachment #8526541 -
Flags: review?(mak77)
Assignee | ||
Comment 98•10 years ago
|
||
Comment on attachment 8526541 [details] [diff] [review] Possible fix Clearing review request. A try run failed: https://treeherder.mozilla.org/ui/logviewer.html#?job_id=3302857&repo=try
Attachment #8526541 -
Flags: review?(mak77)
Comment 99•10 years ago
|
||
Comment on attachment 8526541 [details] [diff] [review] Possible fix Review of attachment 8526541 [details] [diff] [review]: ----------------------------------------------------------------- while here, could you please convert functions that yield to generator (star) functions? ::: toolkit/components/places/tests/unit/test_bookmarks_html.js @@ +284,5 @@ > for (let i = 0; i < root.childCount; i++) { > let child = root.getChild(i); > // This check depends on all "menu" bookmarks being listed first in the imported file :-| > if (i < rootFolderCount) { > + yield checkItem(test_bookmarks.menu[i], child); testImportedBookmarksToFolder is unused, please remove it? @@ +374,5 @@ > do_check_eq(folder.childCount, aExpected.children.length); > > + aExpected.children.forEach(function (item, index) { > + yield checkItem(item, folder.getChild(index)); > + }); this cannot work, you must convert it into a for loop
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Reporter | ||
Comment 216•9 years ago
|
||
Any updates here? Since backing out bug 1083462 seems like a nonstarter, I'm probably going to resort to disabling the test in short order.
Flags: needinfo?(hiikezoe)
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 220•9 years ago
|
||
Oh I am very sorry, I missed Marco's comment in comment #99. I will revise the patch and push a try soon.
Flags: needinfo?(hiikezoe)
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 224•9 years ago
|
||
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=3c08213867c3 This patch could not eliminate the failures. There was one failure in 71 times tries. I am not sure this patch reduced the frequency of failures.
Attachment #8526541 -
Attachment is obsolete: true
Attachment #8533516 -
Flags: review?(mak77)
Comment 225•9 years ago
|
||
Comment on attachment 8533516 [details] [diff] [review] Revised patch Review of attachment 8533516 [details] [diff] [review]: ----------------------------------------------------------------- I think you attached the wrong patch?
Attachment #8533516 -
Flags: review?(mak77) → review-
Assignee | ||
Comment 226•9 years ago
|
||
I am so sorry for my mistake.
Attachment #8533516 -
Attachment is obsolete: true
Attachment #8533656 -
Flags: review?(mak77)
Comment 227•9 years ago
|
||
Comment on attachment 8533656 [details] [diff] [review] Revised patch Review of attachment 8533656 [details] [diff] [review]: ----------------------------------------------------------------- yeah, I'm not sure this is going to reduce the intermittent frequency, but let's see.
Attachment #8533656 -
Flags: review?(mak77) → review+
Updated•9 years ago
|
Keywords: leave-open
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Reporter | ||
Comment 238•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b2e93350b70
Keywords: checkin-needed
Comment hidden (Legacy TBPL/Treeherder Robot) |
Reporter | ||
Comment 240•9 years ago
|
||
(In reply to TBPL Robot from comment #239) This was on the push immediately after comment 238. Looks like your suspicions were confirmed :(
Comment hidden (Legacy TBPL/Treeherder Robot) |
Reporter | ||
Comment 242•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1b2e93350b70
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 248•9 years ago
|
||
Note that in failure case BookmarkHTMLUtils.exportToFile() exported only a few items.
Assignee | ||
Comment 249•9 years ago
|
||
Found the exported bookmarks on local: <!DOCTYPE NETSCAPE-Bookmark-file-1> <!-- This is an automatically generated file. It will be read and overwritten. DO NOT EDIT! --> <META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=UTF-8"> <TITLE>Bookmarks</TITLE> <H1>Bookmarks Menu</H1> <DL><p> </DL>
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 251•9 years ago
|
||
FYI, following change fixed this failure: diff --git a/toolkit/components/places/nsNavHistory.cpp b/toolkit/components/places/nsNavHistory.cpp --- a/toolkit/components/places/nsNavHistory.cpp +++ b/toolkit/components/places/nsNavHistory.cpp @@ -2304,17 +2304,17 @@ nsNavHistory::GetObservers(uint32_t* _co // See RunInBatchMode nsresult nsNavHistory::BeginUpdateBatch() { if (mBatchLevel++ == 0) { mBatchDBTransaction = new mozStorageTransaction(mDB->MainConn(), false, mozIStorageConnection::TRANSACTION_DEFERRED, - true); + false); NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers, nsINavHistoryObserver, OnBeginUpdateBatch()); } return NS_OK; I don't think this change is a right fix though.
Assignee | ||
Comment 252•9 years ago
|
||
OK, I found a solution. I will post a fix soon.
Assignee | ||
Comment 253•9 years ago
|
||
Pushed try now: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=ffd16802d502 I will retrigger this if needed.
Attachment #8534801 -
Flags: review?(mak77)
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 256•9 years ago
|
||
(In reply to Hiroyuki Ikezoe (:hiro) from comment #253) > Created attachment 8534801 [details] [diff] [review] > Fix > > Pushed try now: > > https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=ffd16802d502 > > I will retrigger this if needed. Perfect results: no failures in 100 times tries.
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment 260•9 years ago
|
||
Comment on attachment 8534801 [details] [diff] [review] Fix Review of attachment 8534801 [details] [diff] [review]: ----------------------------------------------------------------- This is a good catch, that may be hinting to the right culprit. Unfortunately, as it is, the patch is just a workaround for some existing bug in BookmarkHTMLUtils.jsm, could be a missing yield or something like that. We must figure if there's something in BookmarkHTMLUtils.jsm that is not properly waiting before working around a bug. If then we figure this is needed for exotic reasons, we can still take it.
Attachment #8534801 -
Flags: review?(mak77)
Assignee | ||
Comment 261•9 years ago
|
||
Good to know. When I wrote comment #251, I had tried to fix the implementation of Places or Sqlite but it was hard to because I am not familiar with those codes. I am very happy that someone else fixes this failure.
Comment 262•9 years ago
|
||
it might be useful to print out the moz_bookmarks table before and after the promiseAsyncUpdates calls, and see how they differ, with dump_table("moz_bookmarks") that could tell us where we stop.
Assignee | ||
Comment 263•9 years ago
|
||
Before: PROCESS | 14653 | *** Printing data from moz_bookmarks PROCESS | 14653 | id type fk parent position title keyword_id folder_type dateAdded lastModified guid PROCESS | 14653 | 1 2 NULL 0 0 NULL NULL 1418300790751480 1418300790751480 root________ PROCESS | 14653 | 2 2 NULL 1 0 Bookmarks Menu NULL NULL 1418300790751480 1418300791576524 menu________ PROCESS | 14653 | 3 2 NULL 1 1 Bookmarks Toolbar NULL NULL 1418300790751480 1177541050000000 toolbar_____ PROCESS | 14653 | 4 2 NULL 1 2 Tags NULL NULL 1418300790751480 1418300790751480 tags________ PROCESS | 14653 | 5 2 NULL 1 3 Unsorted Bookmarks NULL NULL 1418300790751480 1177541050000000 unfiled_____ PROCESS | 14653 | 6 2 NULL 2 0 Mozilla Firefox NULL NULL 1418300790000000 1418300790000000 yXTTg9Yxjd3d PROCESS | 14653 | 7 1 1 6 0 Help and Tutorials NULL NULL 1418300790000000 1418300790000000 dc6yvvs4etXQ PROCESS | 14653 | 8 1 2 6 1 Customize Firefox NULL NULL 1418300790000000 1418300790000000 Wt6q4Yf-2tVg PROCESS | 14653 | 9 1 3 6 2 Get Involved NULL NULL 1418300790000000 1418300790000000 af5exaJq6CvD PROCESS | 14653 | 10 1 4 6 3 About Us NULL NULL 1418300790000000 1418300790000000 sOsFeWT26AbK PROCESS | 14653 | 11 3 NULL 2 1 NULL NULL NULL 1418300791576050 1418300791576050 Df1Lb4z3SUC7 PROCESS | 14653 | 12 2 NULL 2 2 test NULL NULL 1177541020000000 1177541050000000 uxKT6bpuepk3 PROCESS | 14653 | 13 1 5 12 0 test post keyword 7 NULL 1177375336000000 1177375423000000 Y4NanUw2HquG PROCESS | 14653 | 14 1 7 3 0 Getting Started NULL NULL 1418300790000000 1418300790000000 JPr9Ro9fq1MZ PROCESS | 14653 | 15 2 NULL 3 1 Latest Headlines NULL NULL 1418300791581133 1418300791581709 bjbw77xYrLzn PROCESS | 14653 | 16 1 6 5 0 Example.tld NULL NULL 1418300790000000 1418300790000000 yuV3RxTh7jbG PROCESS | 14653 | *** There were a total of 16 rows of data. After: PROCESS | 14653 | *** Printing data from moz_bookmarks PROCESS | 14653 | id type fk parent position title keyword_id folder_type dateAdded lastModified guid PROCESS | 14653 | 1 2 NULL 0 0 NULL NULL 1418300790751480 1418300790751480 root________ PROCESS | 14653 | 2 2 NULL 1 0 Bookmarks Menu NULL NULL 1418300790751480 1418300791576524 menu________ PROCESS | 14653 | 3 2 NULL 1 1 Bookmarks Toolbar NULL NULL 1418300790751480 1177541050000000 toolbar_____ PROCESS | 14653 | 4 2 NULL 1 2 Tags NULL NULL 1418300790751480 1418300790751480 tags________ PROCESS | 14653 | 5 2 NULL 1 3 Unsorted Bookmarks NULL NULL 1418300790751480 1177541050000000 unfiled_____ PROCESS | 14653 | 6 2 NULL 2 0 Mozilla Firefox NULL NULL 1418300790000000 1418300790000000 yXTTg9Yxjd3d PROCESS | 14653 | 7 1 1 6 0 Help and Tutorials NULL NULL 1418300790000000 1418300790000000 dc6yvvs4etXQ PROCESS | 14653 | 8 1 2 6 1 Customize Firefox NULL NULL 1418300790000000 1418300790000000 Wt6q4Yf-2tVg PROCESS | 14653 | 9 1 3 6 2 Get Involved NULL NULL 1418300790000000 1418300790000000 af5exaJq6CvD PROCESS | 14653 | 10 1 4 6 3 About Us NULL NULL 1418300790000000 1418300790000000 sOsFeWT26AbK PROCESS | 14653 | 11 3 NULL 2 1 NULL NULL NULL 1418300791576050 1418300791576050 Df1Lb4z3SUC7 PROCESS | 14653 | 12 2 NULL 2 2 test NULL NULL 1177541020000000 1177541050000000 uxKT6bpuepk3 PROCESS | 14653 | 13 1 5 12 0 test post keyword 7 NULL 1177375336000000 1177375423000000 Y4NanUw2HquG PROCESS | 14653 | 14 1 7 3 0 Getting Started NULL NULL 1418300790000000 1418300790000000 JPr9Ro9fq1MZ PROCESS | 14653 | 15 2 NULL 3 1 Latest Headlines NULL NULL 1418300791581133 1418300791581709 bjbw77xYrLzn PROCESS | 14653 | 16 1 6 5 0 Example.tld NULL NULL 1418300790000000 1418300790000000 yuV3RxTh7jbG PROCESS | 14653 | *** There were a total of 16 rows of data. I can't see any difference between them. Invoking dump_table seems to have the same effect as promiseAsyncUpdates. The following diff was used to get the dumps. diff --git a/toolkit/components/places/tests/unit/test_bookmarks_html.js b/toolkit/components/places/tests/unit/test_bookmarks_html.js --- a/toolkit/components/places/tests/unit/test_bookmarks_html.js +++ b/toolkit/components/places/tests/unit/test_bookmarks_html.js @@ -231,17 +231,21 @@ add_task(function* test_import_ontop() // bookmarks. // 1. empty bookmarks db // 2. import the exported bookmarks file // 3. export to file // 3. import the exported bookmarks file // 4. run the test-suite yield BookmarkHTMLUtils.importFromFile(gBookmarksFileNew, true); - yield BookmarkHTMLUtils.exportToFile(gBookmarksFileNew); + let count = yield BookmarkHTMLUtils.exportToFile(gBookmarksFileNew); + dump_table("moz_bookmarks"); + yield promiseAsyncUpdates(); + dump_table("moz_bookmarks"); + do_check_eq(15, count); yield BookmarkHTMLUtils.importFromFile(gBookmarksFileNew, true); yield promiseAsyncUpdates(); yield testImportedBookmarks(); yield promiseAsyncUpdates(); remove_all_bookmarks(); }); function* testImportedBookmarks()
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Reporter | ||
Updated•9 years ago
|
status-firefox35:
--- → affected
status-firefox36:
--- → affected
status-firefox37:
--- → affected
status-firefox-esr31:
--- → unaffected
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Reporter | ||
Comment 309•9 years ago
|
||
FYI, this is now #4 on OrangeFactor. I'll probably be disabling the test soon if there isn't more progress made.
Assignee: nobody → hiikezoe
Comment 310•9 years ago
|
||
Yeah, I just wanted to ask about the progress here. I think disabling this would indeed be justified, we can always push to try with it re-enabled.
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 315•9 years ago
|
||
Comment on attachment 8534801 [details] [diff] [review] Fix Re-resuesting review. I'd suggest to use this workaround rather than disabling test for now.
Attachment #8534801 -
Flags: review?(mak77)
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment 322•9 years ago
|
||
Comment on attachment 8534801 [details] [diff] [review] Fix Review of attachment 8534801 [details] [diff] [review]: ----------------------------------------------------------------- ok, let's take this for now since we don't have the resources to investigate the actual failure atm, but I need a follow-up bug filed immediately to investigate a proper fix. Link it to this bug for info.
Attachment #8534801 -
Flags: review?(mak77) → review+
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Reporter | ||
Updated•9 years ago
|
Keywords: leave-open → checkin-needed
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Reporter | ||
Comment 331•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/1e94e7f8a32d
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment 334•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1e94e7f8a32d
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla37
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Reporter | ||
Comment 337•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/dfde8f62052f https://hg.mozilla.org/releases/mozilla-beta/rev/096a9cc7a379
Updated•9 years ago
|
Iteration: --- → 37.2
Comment hidden (Legacy TBPL/Treeherder Robot) |
Updated•9 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•