1079399 - Remove Gaiaapps.uninstall because it is unused

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Martijn Wargers (dead)]

I have this code:
    def tearDown(self):
        if self.APP_INSTALLED:
            self.apps.uninstall(self.app_name)

When the test has been finished, the installed app (Calculator) is supposed to be uninstalled.
But that doesn't happen. That piece of code gets stuck on the Delete dialog:
Delete Calculator
Calculator and all of its data will be deleted
Cancel - Delete

This causes this specific test for me to fail when I run it for the 2nd time.

Comment 1

[Martijn Wargers (dead)]

Apparently, the issue has to be fixed somewhere around here: http://mxr.mozilla.org/gaia/source/tests/atoms/gaia_apps.js#366

Comment 2

[Zac C (:zac)]

Yeah ie does not surprise me that this has rot. We used to use it but at the moment we don't use this method at all; we rely on cleanup_data() method in the setUp to configure the device because we found that when the device crashes the tearDown doesn't get executed. The setUp is much more trustworthy.

That said, this should be fixable and if someone does can they create a unit test for it?

Comment 3

[Martijn Wargers (dead)]

test_homescreen_delete_app.py does it this way:
http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/tests/functional/homescreen/test_homescreen_delete_app.py#54
self.homescreen.installed_app(self.test_data['name']).tap_delete_app().tap_confirm()
tap_delete_app returns ConfirmDialog.

http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/apps/homescreen/regions/confirm_dialog.py

self.apps.uninstall is this:
http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/gaia_test.py#94

So I guess a gaia-ui-test just always has to add a ConfirmDialog.tap_confirm() to it.

Comment 4

[Zac C (:zac)]

(In reply to Martijn Wargers [:mwargers] (QA) from comment #3)
> So I guess a gaia-ui-test just always has to add a
> ConfirmDialog.tap_confirm() to it.

Yes I agree with this. It would not be consistent with the style of GaiaApps to have uninstall return the app object or a UI class.

Another alternative is to just remove the method entirely so it doesn't rot again. It's unused now so the impact is low.

Comment 5

[Martijn Wargers (dead)]

Attachment: patch

(In reply to Zac C (:zac) from comment #4)
> Another alternative is to just remove the method entirely so it doesn't rot
> again. It's unused now so the impact is low.

Yeah, I agree. It's unused and I don't need it, either.

Comment 6

[Zac C (:zac)]

Comment on attachment 8509983 [details] [review]
patch

r+

Comment 7

[Zac C (:zac)]

Merged:
https://github.com/mozilla-b2g/gaia/commit/df899a8988de61faf85ce0dd6a7a39cf92fe9042

Comment 8

[Martijn Wargers (dead)]

Haha, I readded this function again in bug 1150009, but this time it has some uses.