Closed Bug 1079432 Opened 5 years ago Closed 5 years ago

Turn off js minification in debug builds

Categories

(Firefox Build System :: General, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla35

People

(Reporter: jlal, Assigned: jlal)

Details

Attachments

(1 file, 1 obsolete file)

Debugging everything on line 1 is less then ideal we should turn this off at least for debug builds and probably on desktop as a whole. See Bug 903149 for context.

Some links:
http://mxr.mozilla.org/mozilla-central/source/b2g/installer/Makefile.in#60
 http://mxr.mozilla.org/mozilla-central/source/b2g/installer/Makefile.in#43
Comment on attachment 8501261 [details] [diff] [review]
Turn off minification in debug builds

Review of attachment 8501261 [details] [diff] [review]:
-----------------------------------------------------------------

Is this sane?
Attachment #8501261 - Flags: feedback?(mshal)
Comment on attachment 8501261 [details] [diff] [review]
Turn off minification in debug builds

Seems reasonable to me. There may be a better solution buried somewhere in bug 903149, but in the meantime this is better than hacking up the Makefile locally to disable the minifier.
Attachment #8501261 - Flags: feedback?(mshal) → review+
quick sanity check on try: https://tbpl.mozilla.org/?tree=Try&rev=b8e44cc360eb (will land on green)
Attachment #8501261 - Attachment is obsolete: true
Attachment #8501395 - Flags: review?(mshal)
Comment on attachment 8501395 [details] [diff] [review]
Turn off minification in debug builds

Carrying r+ forward missed the r=mshal in the patch
Attachment #8501395 - Flags: review?(mshal) → review+
Keywords: checkin-needed
Assignee: nobody → jlal
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/fe0ccde065c6
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.