Closed
Bug 1079432
Opened 10 years ago
Closed 10 years ago
Turn off js minification in debug builds
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla35
People
(Reporter: jlal, Assigned: jlal)
Details
Attachments
(1 file, 1 obsolete file)
874 bytes,
patch
|
jlal
:
review+
|
Details | Diff | Splinter Review |
Debugging everything on line 1 is less then ideal we should turn this off at least for debug builds and probably on desktop as a whole. See Bug 903149 for context. Some links: http://mxr.mozilla.org/mozilla-central/source/b2g/installer/Makefile.in#60 http://mxr.mozilla.org/mozilla-central/source/b2g/installer/Makefile.in#43
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8501261 [details] [diff] [review] Turn off minification in debug builds Review of attachment 8501261 [details] [diff] [review]: ----------------------------------------------------------------- Is this sane?
Attachment #8501261 -
Flags: feedback?(mshal)
Comment 3•10 years ago
|
||
Comment on attachment 8501261 [details] [diff] [review] Turn off minification in debug builds Seems reasonable to me. There may be a better solution buried somewhere in bug 903149, but in the meantime this is better than hacking up the Makefile locally to disable the minifier.
Attachment #8501261 -
Flags: feedback?(mshal) → review+
Assignee | ||
Comment 4•10 years ago
|
||
quick sanity check on try: https://tbpl.mozilla.org/?tree=Try&rev=b8e44cc360eb (will land on green)
Assignee | ||
Comment 5•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8501261 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
Attachment #8501395 -
Flags: review?(mshal)
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8501395 [details] [diff] [review] Turn off minification in debug builds Carrying r+ forward missed the r=mshal in the patch
Attachment #8501395 -
Flags: review?(mshal) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → jlal
Status: NEW → ASSIGNED
Comment 7•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/fe0ccde065c6
Keywords: checkin-needed
Comment 8•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/fe0ccde065c6
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•