[PulseGuardian] Detection of queues can be simplified

RESOLVED FIXED

Status

P2
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mcote, Assigned: mcote)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [lang=python])

(Assignee)

Description

4 years ago
guardian.py has a roundabout way of finding the owner of a given queue: it looks for any active connections (normally only one) and sets the user of that connection as the queue's owner.  If it doesn't find one (client hung up right away or can't stay connected for long), the queue is orphaned, and no one is emailed about it if it gets too big and/or is deleted (at least until bug 832415 is fixed).

However, this was conceived before we settled on a restrictive naming convention.  Now you can easily tell the owner of a queue (or an exchange, see bug 1079523) from its name, e.g., queue/<username>/...  We might as well just use that method in guardian.py.
(Assignee)

Comment 1

4 years ago
This bit me again today due to my terrible memory.  Going to fix this.
Assignee: nobody → mcote
Status: NEW → ASSIGNED
(Assignee)

Updated

4 years ago
Priority: P3 → P2
(Assignee)

Comment 2

4 years ago
Fixed and added test for abnormal queue names.  Did a bunch of cleanup at the same time.

https://github.com/mozilla/pulseguardian/commit/3b62a48e577f82d1f01625d977cc157a57b9f48e
Mentor: mcote
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
User Story: (updated)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.