Closed Bug 1079650 Opened 5 years ago Closed 5 years ago

Eliminate the ragged columns of the Initials buttons with a consistent spacing

Categories

(Tree Management :: Treeherder, defect, P5, trivial)

defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: jfrench, Assigned: jfrench)

References

()

Details

Attachments

(1 file)

Another one of those minor polish things.

The ragged columns produced by the varying widths of the Initials buttons is distracting and could be improved. Instead it would be reasonable to have a uniform width. This will create consistent negative space around the content in that block.

I'm already looking at it, so will assign myself shortly.
Assignee: nobody → tojonmz
Status: NEW → ASSIGNED
Attached file treeherder-ui-PR#222
Please see the above PR for review and status.
Attachment #8501507 - Flags: review?(wlachance)
Looks much better - thank you for all these polish patches, cumulatively they make a huge difference to the perceived visual quality of treeherder.
Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/d6432609b74ffb2077ac455a636b142f30cf2744
Bug 1079650 - Give the Initials buttons consistent size and spacing

https://github.com/mozilla/treeherder-ui/commit/b081f697f225d7b90454ab1e43833b98fed20d1d
Merge pull request #222 from tojonmz/consistent-initialblock

Bug 1079650 - Give the Initials buttons consistent size and spacing
Comment on attachment 8501507 [details] [review]
treeherder-ui-PR#222

lgtm!
Attachment #8501507 - Flags: review?(wlachance) → review+
I'll verify this bug on the next push to dev/stage, tbd.
Verified fixed and working correctly on dev/stage.
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/cdf23e86b1bb29cab673fa79cca4216973e05b74
Bug 1079650 - Give the Initials buttons consistent size and spacing

https://github.com/mozilla/treeherder/commit/6fbae89fdeb0e17c2dcaea7c9936604288be70e3
Merge pull request #222 from tojonmz/consistent-initialblock

Bug 1079650 - Give the Initials buttons consistent size and spacing
You need to log in before you can comment on or make changes to this bug.