If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Clicking the "Account" item in the Gear menu doesn't work if you are logged in from startup

VERIFIED FIXED in Firefox 34

Status

Hello (Loop)
Client
P2
normal
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: MattN, Assigned: MattN)

Tracking

unspecified
mozilla36
Points:
5
Bug Flags:
firefox-backlog +
in-testsuite +
qe-verify -

Firefox Tracking Flags

(firefox33 unaffected, firefox34+ fixed, firefox35+ verified, firefox36 verified)

Details

Attachments

(1 attachment)

"TypeError: gFxAOAuthClient is null" on MozLoopService.jsm:1603

We haven't created gFxAOAuthClient since we were already logged in.

We will probably want to use promiseFxAOAuthParameters in that case but we should avoid the HTTP request on every click of the Account option (for snappiness reasons) by caching params somewhere.
Flags: qe-verify+
Flags: firefox-backlog+
Flags: in-testsuite?
Assignee: nobody → MattN+bmo
Status: NEW → ASSIGNED
Iteration: --- → 35.3
Points: --- → 5
status-firefox34: --- → affected
status-firefox35: --- → affected
Created attachment 8504447 [details] [diff] [review]
v.1 yield on promiseFxAOAuthClient
Attachment #8504447 - Flags: review?(jaws)
Flags: in-testsuite? → in-testsuite+
Comment on attachment 8504447 [details] [diff] [review]
v.1 yield on promiseFxAOAuthClient

Review of attachment 8504447 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/loop/test/mochitest/browser_fxa_login.js
@@ +395,5 @@
> +add_task(function* openFxASettings() {
> +  yield resetFxA();
> +
> +  // Since the default b-c window has a blank tab, open a new one to properly
> +  // test switchToTabHavingURI.

// Since the default b-c window has a blank tab, open a new non-blank tab to
// force switchToTabHavingURI to open a new tab instead of reusing the current
// blank tab.
Attachment #8504447 - Flags: review?(jaws) → review+
https://hg.mozilla.org/integration/fx-team/rev/474d1663c2e0
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/474d1663c2e0
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla35
status-firefox36: --- → fixed
Target Milestone: mozilla35 → mozilla36

Updated

3 years ago
backlog: --- → Fx35+
Paul, can you please verify this is fixed in tomorrow's Nightly?
Flags: needinfo?(paul.silaghi)
QA Contact: anthony.s.hughes → paul.silaghi
backlog: Fx35+ → Fx34+
Comment on attachment 8504447 [details] [diff] [review]
v.1 yield on promiseFxAOAuthClient

Approval Request Comment
[Feature/regressing bug #]: FxA Account access
[User impact if declined]: Menu item sometimes works and sometimes doesn't
[Describe test coverage new/current, TBPL]: landed in m-c, tested manually
[Risks and why]: very specific to Hello; without this, the user may not be able to go to the manage account page
[String/UUID change made/needed]: No string
Attachment #8504447 - Flags: approval-mozilla-beta?
Attachment #8504447 - Flags: approval-mozilla-aurora?
[Tracking Requested - why for this release]:

We want to uplift this, see Comment 6
tracking-firefox34: --- → ?
Verified fixed 36.0a1 (2014-10-16) Win 7, OS X 10.9.5
Status: RESOLVED → VERIFIED
status-firefox36: fixed → verified
Flags: needinfo?(paul.silaghi)
status-firefox33: --- → wontfix
tracking-firefox34: ? → +
tracking-firefox35: --- → +
status-firefox33: wontfix → unaffected
Comment on attachment 8504447 [details] [diff] [review]
v.1 yield on promiseFxAOAuthClient

Beta+
Aurora+
Attachment #8504447 - Flags: approval-mozilla-beta?
Attachment #8504447 - Flags: approval-mozilla-beta+
Attachment #8504447 - Flags: approval-mozilla-aurora?
Attachment #8504447 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/ef87188cc41e
status-firefox35: affected → fixed
Tested and good on Aurora nightly build; windows and linux.
https://hg.mozilla.org/releases/mozilla-beta/rev/ada526904539
status-firefox34: affected → fixed
I'm deprioritizing this for further QE testing as this has already been verified in Nightly and Aurora. We've got more important bugs that need testing right now but may loop back around to this if time allows.
status-firefox35: fixed → verified
Flags: qe-verify+ → qe-verify-
You need to log in before you can comment on or make changes to this bug.