1079699 - The src of homescreen iframe is really long

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Ting-Yu Chou [:ting] (away)]

+++ This bug was initially created as a clone of Bug #1076605 +++

This is spin off from bug 1076605 comment 14 that the src of homescreen iframe becomes really long after MTBF. It's like:

<iframe mozallowfullscreen="true" mozbrowser="true" name="main" remote="true" mozapp="app://verticalhome.gaiamobile.org/manifest.webapp" mozapptype="homescreen" src="app://verticalhome.gaiamobile.org/index.html#root14125903796341412590449855141259048842214125905102011412590515486141259053118314125905331261412590545761141259056248614125905841181412590589484141259062526614125906631821412590709327141259074238114125907671791412590792050141259081968914125908405121412590853337141259087424114125908795801412590906445141259092344014125909254061412590930912141259096273214125909961861412591021904141259104851014125910712681412591092072141259109...

The numbers are Date added from:

  http://lxr.mozilla.org/gaia/source/apps/system/js/homescreen_window.js#198

Note changing the src triggers aw__handle_mozbrowserlocationchange() which changes this.config.url, so the Date will actually be appended and create the long src.

Comment 1

[Ting-Yu Chou [:ting] (away)]

NI Alive as he owns the code.

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

Kevin could you take care this one?

Comment 3

[Kevin Grandon :kgrandon]

Funny. Sure, doesn't seem too bad to fix.

Comment 4

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Comment 5

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8501812 [details] [review]
Github pull request

Nice catch, looks good to me

Comment 6

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/11ef00785cf933165fa021d7a46b95a27c1600d6

Comment 7

[Ting-Yu Chou [:ting] (away)]

I guess we need the patch to be uplifted, the src grows to 1.x MB while running MTBF on v2.1.

Comment 8

[Kevin Grandon :kgrandon]

Comment on attachment 8501812 [details] [review]
Github pull request

Requesting uplift per comment 7.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): I think this has been here forever.
[User impact] if declined: Increased memory usage over time, you can see this just by pressing the home button a few hundred times.
[Testing completed]: Manual and unit tests.
[Risk to taking this patch] (and alternatives if risky): Low risk, 2 line change.
[String changes made]: None.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/ecf10447e686e4236768e7d8ec2d6ffc161d4961