1079758 - Send notification on start log shake capture

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[:gerard-majax]

For better user feedback, since dumping logs can take some time, it could be good to send a first notification when we start the capture.

Comment 1

[:gerard-majax]

Attachment: Send logshake capture start event r=gwagner

Comment 2

[:gerard-majax]

Attachment: Gaia PR

Not yet with tests.

Comment 3

[:gerard-majax]

Comment on attachment 8501653 [details] [review]
Gaia PR

Jan, I'm asking you the review given the dev-gaia thread and Fabrice's reply.
Try looks green: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=6ca27f1bfb75

Comment 4

[Jan Keromnes [:janx]]

Comment on attachment 8501646 [details] [diff] [review]
Send logshake capture start event r=gwagner

Review of attachment 8501646 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/components/LogShake.jsm
@@ +57,5 @@
>  const DEVICE_MOTION_EVENT = 'devicemotion';
>  const SCREEN_CHANGE_EVENT = 'screenchange';
>  const CAPTURE_LOGS_ERROR_EVENT = 'capture-logs-error';
>  const CAPTURE_LOGS_SUCCESS_EVENT = 'capture-logs-success';
> +const CAPTURE_LOGS_START_EVENT = 'capture-logs-start';

Optional super-nit: Defining the START event above the ERROR and SUCCESS events would be slightly more readable.

Comment 5

[Jan Keromnes [:janx]]

Comment on attachment 8501653 [details] [review]
Gaia PR

Try is green and it works great.

(Unrelated issue, since I don't have an SD card, LogShake fails with "The logs could not be saved [object Object]".)

r=me, nice one!

Comment 6

[:gerard-majax]

Attachment: Send logshake capture start event r=gwagner

Comment 7

[:gerard-majax]

Comment on attachment 8502271 [details] [diff] [review]
Send logshake capture start event r=gwagner

Carrying f+ from attachment 8501646 [details] [diff] [review]

Addressed nit.

Comment 8

[:gerard-majax]

Try is green for gaia: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=424bcc22f3d5

Comment 9

[:gerard-majax]

Gaia merged: https://github.com/mozilla-b2g/gaia/commit/bd94d3a3e50be287c906043dd7dd946ddf816ff4

Comment 10

[Francesco Lodolo [:flod]]

If this string is going to be exposed somewhere in the UI, it should be

> Capturing logs…

(no space before ellipsis, single unicode character for ellipsis)

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/b2g-inbound/rev/ec008b16c0d4

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ec008b16c0d4