1079805 - WARNING: content window passed to PrivateBrowsingUtils.isWindowPrivate from network-monitor.js

Status: RESOLVED DUPLICATE of bug 1121765

(DevTools :: Netmonitor, defect)

Description

[Brian Grinstead [:bgrins]]

When running via ./mach run I see this error in stdout often.  If you don't see it immediately, try opening the network monitor then reloading a page.

WARNING: content window passed to PrivateBrowsingUtils.isWindowPrivate. Use isContentWindowPrivate instead (but only for frame scripts).
pbu_isWindowPrivate@resource://gre/modules/PrivateBrowsingUtils.jsm:25:14
NM__onRequestHeader@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/toolkit/webconsole/network-monitor.js:653:34
NM_observeActivity@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/toolkit/webconsole/network-monitor.js:532:7
makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:83:14

Comment 1

[Chris Peterson [:cpeterson]]

I still see this error on stdout all the time:

> WARNING: content window passed to PrivateBrowsingUtils.isWindowPrivate. Use isContentWindowPrivate instead (but only for frame scripts).
> pbu_isWindowPrivate@resource://gre/modules/PrivateBrowsingUtils.jsm:25:14
> NM__onRequestHeader@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/toolkit/webconsole/network-monitor.js:668:34
> NM_observeActivity@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/toolkit/webconsole/network-monitor.js:547:7
> makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:82:14

Comment 2

[Brian Grinstead [:bgrins]]

Victor, we can't use `PrivateBrowsingUtils.isWindowPrivate` anymore with content windows [0] as we do in network-monitor.js [1].  The recommendation now is to use `isBrowserPrivate` [2] since it works in e10s.  We need to find the browser associated with a particular channel so we can appropriately decide if it's a private request.  Any ideas how to get this info?

[0]: https://dxr.mozilla.org/mozilla-central/source/toolkit/modules/PrivateBrowsingUtils.jsm?from=privatebrowsingutils.jsm#21
[1]: https://dxr.mozilla.org/mozilla-central/source/toolkit/devtools/webconsole/network-monitor.js?from=network-monitor.js#668
[2]: https://dxr.mozilla.org/mozilla-central/source/toolkit/modules/PrivateBrowsingUtils.jsm?from=privatebrowsingutils.jsm#36

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Brian Grinstead [:bgrins] from comment #2)
> Victor, we can't use `PrivateBrowsingUtils.isWindowPrivate` anymore with
> content windows [0] as we do in network-monitor.js [1].  The recommendation
> now is to use `isBrowserPrivate` [2] since it works in e10s.  We need to
> find the browser associated with a particular channel so we can
> appropriately decide if it's a private request.  Any ideas how to get this
> info?
> 
> [0]:
> https://dxr.mozilla.org/mozilla-central/source/toolkit/modules/
> PrivateBrowsingUtils.jsm?from=privatebrowsingutils.jsm#21
> [1]:
> https://dxr.mozilla.org/mozilla-central/source/toolkit/devtools/webconsole/
> network-monitor.js?from=network-monitor.js#668
> [2]:
> https://dxr.mozilla.org/mozilla-central/source/toolkit/modules/
> PrivateBrowsingUtils.jsm?from=privatebrowsingutils.jsm#36

A patch that appears to make the needed change is up for review in bug 1121765.

Maybe this can just depend on that one?

Comment 4

[Brian Grinstead [:bgrins]]

(In reply to J. Ryan Stinnett [:jryans] from comment #3)
> A patch that appears to make the needed change is up for review in bug
> 1121765.
> 
> Maybe this can just depend on that one?

Ah, nice!  Going to just dup this one since that should fix it outright.