1079865 - Gaia doesn't start on windows

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Alexandre Poirot [:ochameau]]

Since bug 1022767, attachment 8490190 [details] [review] landed, gaia build system throws on Windows.
For some unknown reason, tbpl is still happy, even if we can see this exception over here:
https://tbpl.mozilla.org/php/getParsedLog.php?id=49795433&tree=Mozilla-Central#error0
Because of this exception, we end up *not* building application.zip files!
That is most likely gaia build system fault by not returning an explicit error code...
Let's improve that in bug 1074200 and ensure that build system quit with an error code when such error happens.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Pull request 24944

Gandalf, I tried to be very conservative in this fix. So I don't expect to regress anything. The feedback is more to let you know about win32 paths...

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8501740 [details] [review]
Pull request 24944

Thanks! Should we try to fix utils.basename/dirname? It sucks that it doesn't work on Windows

Comment 3

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8501740 [details] [review]
Pull request 24944

Thanks for the fix.
However, the build test fail, so I just made a pr to your branch. Please also kindly check and merge. Thanks.

Comment 4

[(Inactive after June) George Duan [:gduan] [:喬智]]

I agree,
I think we should fix utils.dirName and utils.baseName to make sure the utils work fine in windows.

Alex, What do you think?

(In reply to Zibi Braniecki [:gandalf] from comment #2)
> Comment on attachment 8501740 [details] [review]
> Pull request 24944
> 
> Thanks! Should we try to fix utils.basename/dirname? It sucks that it
> doesn't work on Windows

Comment 5

[Alexandre Poirot [:ochameau]]

(In reply to George Duan [:gduan] [:喬智] from comment #4)
> I agree,
> I think we should fix utils.dirName and utils.baseName to make sure the
> utils work fine in windows.

In this particular code, we are overusing nsIFile API so there is no need to use utils.* helpers here.
Otherwise I agree with the idea of fixing stuff for windows, but I think it would be even better to just use `path` module available in the SDK, instead of crafting our own path handling module. (path module already works with windows paths)
(require(sdk/fs/path) it has the same API than nodejs path module)

Comment 6

[Alexandre Poirot [:ochameau]]

Try looks green after some rebases.

Comment 7

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/83a8caf809a2d7a159376133e89e5c8a6937d9fc