Closed Bug 1079959 Opened 5 years ago Closed 5 years ago

Google import fails if a contact contains a physical address

Categories

(Hello (Loop) :: Client, defect)

defect
Not set

Tracking

(firefox34 verified, firefox35 verified)

VERIFIED FIXED
mozilla35
Iteration:
35.3
Tracking Status
firefox34 --- verified
firefox35 --- verified

People

(Reporter: abr, Assigned: abr)

Details

(Whiteboard: [loop-uplift])

Attachments

(1 file)

When attempting to import contacts from Google, the following exception is
thrown and processing stops if any contact contains a physical address:

*************************
A coding exception was thrown and uncaught in a Task.

Full message: ReferenceError: contacts is not defined
Full stack: this.GoogleImporter.prototype._processContactFields@resource:///modules/loop/GoogleImporter.jsm:428:11
this.GoogleImporter.prototype._processContacts<@resource:///modules/loop/GoogleImporter.jsm:362:21
TaskImpl_run@resource://gre/modules/Task.jsm:314:40
TaskImpl@resource://gre/modules/Task.jsm:275:3
createAsyncFunction/asyncFunction@resource://gre/modules/Task.jsm:249:14
this.GoogleImporter.prototype.startImport/<@resource:///modules/loop/GoogleImporter.jsm:172:41
TaskImpl_run@resource://gre/modules/Task.jsm:314:40
Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:865:23
this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:744:7

*************************

This appears to be a simple typo in the importer.
Replace "contacts" with "contact" in physical address import block
Attachment #8501839 - Flags: review?(mdeboer)
Comment on attachment 8501839 [details] [diff] [review]
Google import fails if a contact contains a physical address

Review of attachment 8501839 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/loop/GoogleImporter.jsm
@@ +424,5 @@
>          ]), addressNode, kNS_GD);
>          if (Object.keys(adr).length) {
>            adr.pref = (addressNode.getAttribute("primary") == "true");
>            adr.type = [getFieldType(addressNode)];
> +          contact.adr.push(adr);

ough! :( thanks for fixing this!
Attachment #8501839 - Flags: review?(mdeboer) → review+
Whiteboard: [loop-uplift]
Flags: qe-verify+
https://hg.mozilla.org/mozilla-central/rev/47eeb8bea13c
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Verified fixed 35.0a1 (2014-10-09), OS X 10.9.5.
Importing on Win and Linux is still under investigation in bug 1069816.
Status: RESOLVED → VERIFIED
Comment on attachment 8501839 [details] [diff] [review]
Google import fails if a contact contains a physical address

Approval Request Comment
Part of the staged Loop aurora second uplift set
Attachment #8501839 - Flags: approval-mozilla-aurora?
Flags: needinfo?(paul.silaghi)
Verified fixed FF 34b1 Win 7
Flags: needinfo?(paul.silaghi)
Comment on attachment 8501839 [details] [diff] [review]
Google import fails if a contact contains a physical address

Post landed approval (already landed)
Attachment #8501839 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Iteration: --- → 35.3
You need to log in before you can comment on or make changes to this bug.