1080082 - Change Feedback URL for Firefox Developer Edition

Status: RESOLVED DUPLICATE of bug 1072181

(Firefox :: General, defect)

Description

[Tyler Downer [He/Him]]

we should change the feedback URL for the Firefox dev edition to enable differentiation between regular Aurora and dev edition feedback.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Input doesn't really have a good way to do this unless we make this a separate product. The url scheme looks like this:

https://wiki.mozilla.org/Firefox/Input/Feedback_urls

Comment 2

[[:Cww]]

Honestly, I think it's good enough to add a source=product, campaign=dev_edition or something like that at least for this round. When we decide what the long term prospects are for the dev edition, we can come up with a better long term plan.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

I talked with the illustrious Cheng and Gregg on the IRCs and we talked about the various places we could save data to differentiate this to more easily analyze the resulting feedback. We decided the best thing to do is to have this be another Input product.

We suggest you change app.feedback.baseURL <http://dxr.mozilla.org/mozilla-central/source/browser/app/profile/firefox.js#1153> from this:

https://input.mozilla.org/%LOCALE%/feedback/%APP%/%VERSION%/

to this:

https://input.mozilla.org/%LOCALE%/feedback/firefoxdev/%VERSION%/

That makes this the "firefoxdev" product.

If that sounds ok, then I'll create a produce on Input dev, stage and prod environments.

Comment 4

[Axel Hecht [:Pike]]

Note, not all users of aurora will be web developers, it's a shared build with the l10n testing audience.

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: devedition-feedback-url-1080082.patch

(In reply to Will Kahn-Greene [:willkg] from comment #3)
> I talked with the illustrious Cheng and Gregg on the IRCs and we talked
> about the various places we could save data to differentiate this to more
> easily analyze the resulting feedback. We decided the best thing to do is to
> have this be another Input product.
> 
> We suggest you change app.feedback.baseURL
> <http://dxr.mozilla.org/mozilla-central/source/browser/app/profile/firefox.
> js#1153> from this:
> 
> https://input.mozilla.org/%LOCALE%/feedback/%APP%/%VERSION%/
> 
> to this:
> 
> https://input.mozilla.org/%LOCALE%/feedback/firefoxdev/%VERSION%/
> 
> That makes this the "firefoxdev" product.
> 
> If that sounds ok, then I'll create a produce on Input dev, stage and prod
> environments.

I have changed this in browser/branding/aurora/pref/firefox-branding.js as these are the Aurora pref overrides... hopefully this works for you.

Not much to review here but asking for one just in case.

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

Michael: Did you do a test feedback to make sure it's working right? I don't see anything for the firefoxdev product.

FYI, the product exists in our -stage and -prod environments, but it's marked as "not public" so responses won't show up on the dashboard. But if you leave a feedback and let me know, I can find it.

Comment 7

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: devedition-feedback-url-1080082.patch

Not much to see here either but a review won't do any harm.

We now choose the firefoxdev URL when Firefox was built with MOZ_DEV_EDITION.

Comment 8

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

(In reply to Will Kahn-Greene [:willkg] from comment #6)
> Michael: Did you do a test feedback to make sure it's working right? I don't
> see anything for the firefoxdev product.
> 
> FYI, the product exists in our -stage and -prod environments, but it's
> marked as "not public" so responses won't show up on the dashboard. But if
> you leave a feedback and let me know, I can find it.

I have left feedback when creating this second patch.

Comment 9

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Switched back to the original patch as the team agree it is the better approach.

Comment 10

[Will Kahn-Greene [:willkg] ET needinfo? me]

I verified the feedback left is there and in the right product and I verified it's not showing up on the dashboard right now:

https://input.mozilla.org/en-US/dashboard/response/4660100

For the record, we can change the display name (currently "Firefox dev") and whether or not it shows up on the dashboard pretty easily. Just let me know when/if we want to do that.

Comment 11

[Joe Walker [:jwalker]]

Obviously this end of that file is very contended. Maybe we should just join this with bug 1082632 and bug 1082584.

Comment 12

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

The patch has been added to bug 1082584.

Comment 13

[Joe Walker [:jwalker]]

(In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #12)
> The patch has been added to bug 1082584.

Could you join the patches together and resolve the conflicts?

Comment 14

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

(In reply to Joe Walker [:jwalker] (overloaded - needinfo me or ping on irc) from comment #13)
> (In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #12)
> > The patch has been added to bug 1082584.
> 
> Could you join the patches together and resolve the conflicts?

Done

Comment 15

[Joe Walker [:jwalker]]

Changes landing in bug 1072181.