don't redefine STATUS_FLOAT_* values in nsSigHandlers.cpp

RESOLVED FIXED in mozilla36

Status

()

Toolkit
General
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

unspecified
mozilla36
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Including <windows.h> picks these up, as recent builds indicate by warning:

c:\builds\moz2_slave\m-in-w32-000000000000000000000\build\toolkit\xre\nsSigHandlers.cpp(341) : warning C4005: 'STATUS_FLOAT_MULTIPLE_FAULTS' : macro redefinition
        c:\Program Files (x86)\Windows Kits\8.0\include\um\winnt.h(2127) : see previous definition of 'STATUS_FLOAT_MULTIPLE_FAULTS'
c:\builds\moz2_slave\m-in-w32-000000000000000000000\build\toolkit\xre\nsSigHandlers.cpp(342) : warning C4005: 'STATUS_FLOAT_MULTIPLE_TRAPS' : macro redefinition
        c:\Program Files (x86)\Windows Kits\8.0\include\um\winnt.h(2128) : see previous definition of 'STATUS_FLOAT_MULTIPLE_TRAPS'
Created attachment 8502006 [details] [diff] [review]
don't redefine STATUS_FLOAT_* values in nsSigHandlers.cpp

Including <windows.h> picks these up, as recent builds indicate by warning:

c:\builds\moz2_slave\m-in-w32-000000000000000000000\build\toolkit\xre\nsSigHandlers.cpp(341) : warning C4005: 'STATUS_FLOAT_MULTIPLE_FAULTS' : macro redefinition
        c:\Program Files (x86)\Windows Kits\8.0\include\um\winnt.h(2127) : see previous definition of 'STATUS_FLOAT_MULTIPLE_FAULTS'
c:\builds\moz2_slave\m-in-w32-000000000000000000000\build\toolkit\xre\nsSigHandlers.cpp(342) : warning C4005: 'STATUS_FLOAT_MULTIPLE_TRAPS' : macro redefinition
        c:\Program Files (x86)\Windows Kits\8.0\include\um\winnt.h(2128) : see previous definition of 'STATUS_FLOAT_MULTIPLE_TRAPS'
Attachment #8502006 - Flags: review?(benjamin)

Updated

3 years ago
Attachment #8502006 - Flags: review?(benjamin) → review+
https://hg.mozilla.org/mozilla-central/rev/e503b8a45bec
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.