1080148 - Default contact picture should contain the first letter of the contact name

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Marcia Knous [:marcia]]

Attachment: Contact as displayed in Contacts app

Flame, while running:

Gaia   0bc74ce502672cf0265b24cf3a25d117c3de5e71
SourceStamp e4cfacb76830
BuildID 20141008040203
Version 35.0a1
Base: v184

STR:
1. Add a contact with the last name K, without a picture
2. Start a message thread with that contact
3. Observe the attached screenshot

Expected: In both contacts and Message app with default picture would be the same (Blue circle with capital K)

Comment 1

[Marcia Knous [:marcia]]

Attachment: Contact in Messaging App

Comment 2

[Johan Lorenzo [:jlorenzo]]

Per bug 1003843, it seems to be the expected behavior in the Message app. Can you confirm, Fang?

Comment 3

[Fang Shih [:fang]]

Attachment: Messaging_inbox.png

Follow the style of the default image. We should have the same behavior for Message app as well. Thanks!

Comment 4

[Johan Lorenzo [:jlorenzo]]

[Blocking Requested - why for this release]: Confusing behavior on a new feature.

Comment 5

[Julien Wajsberg [:julienw]]

Hi Fang, I'm really not sure about this.

Some good reasons:
* in Contacts app, the letter will change depending whether we sort by first name or last name. We can't do this in the Messages app because we don't know the sort.
* in Contacts app, the letter helps to know in which part of the contact list we are; in the Messages app, this has no real use.

In the end, I think it clutters the view for no real benefit for the user.

NI Jenny and Fang about this. Thanks !

Comment 6

[Jenny Lee]

Hello Julien,

The main purpose for showing a preset contact picture is to distinguish recipients that are saved from the ones not saved; the presence of picture also gives a sense of richness in terms of visual (as opposed to a view filled with text). On top of that, I think it's important to have consistency among comms apps, the experience of contact associated with a picture is established in Contacts, so in Messages, having similar design can reinforce that style. 

About the sorting.. is there nothing we can do to get the sorting order from Contacts? If so, using the default setting should be fine. Thanks!

Comment 7

[Julien Wajsberg [:julienw]]

(In reply to Jenny Lee from comment #6)
> Hello Julien,
> 
> The main purpose for showing a preset contact picture is to distinguish
> recipients that are saved from the ones not saved; the presence of picture
> also gives a sense of richness in terms of visual (as opposed to a view
> filled with text). On top of that, I think it's important to have
> consistency among comms apps, the experience of contact associated with a
> picture is established in Contacts, so in Messages, having similar design
> can reinforce that style. 

Hey Jenny,

I just want to say I have nothing against the preset contact picture, but against the letter inside the default picture.

> 
> About the sorting.. is there nothing we can do to get the sorting order from
> Contacts? If so, using the default setting should be fine. Thanks!

Francisco, can you answer this? Is it in eg a mozSetting?

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

(In reply to Julien Wajsberg [:julienw] from comment #7)

> 
> Francisco, can you answer this? Is it in eg a mozSetting?

Unfortunately is not in a mozSetting, it's saved internally as it used to be a contacts feature.

We can share it via DS if needed.

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

(In reply to Francisco Jordano [:arcturus] [:francisco] from comment #8)
> 
> We can share it via DS if needed.

That will be a real extreme case ;)

Ideally, I would love to move contacts settings to settings app, and this kind of elements being a proper setting that everyone can use.

With that said, that will require a lot of planned work.

Comment 10

[Julien Wajsberg [:julienw]]

I don't think it' s worth it...

NI Jenny with the new information.

Comment 11

[Jenny Lee]

(In reply to Julien Wajsberg [:julienw] from comment #10)
> I don't think it' s worth it...
> 
> NI Jenny with the new information.

Hey Julien,
So your main concern is not knowing what letter to display on preset picture? 
Since it's unlikely for us to get the sorting info in near future, I suggest in Message we simply use the first letter of first name (which is the default sorting in contact). Is that acceptable?

Comment 12

[Julien Wajsberg [:julienw]]

We can try and see how this looks.

As there is no urgency, I'm making this bug a mentored bug. The code to change is in apps/sms/js/thread_list_ui.js, the function is `setContact`, and more exactly the inner function `updateThreadNode`.

You can follow the steps at [1] to run the application inside Firefox.

[1] https://github.com/julienw/gaia/blob/1082618-sms-readme/apps/sms/README.md

If the bug is not fixed quick enough, the SMS team can take it.

Comment 13

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: this is feature

Comment 14

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

[Tracking Requested - why for this release]:
not in 2.2 must-have scope.

Comment 15

[ankitladhania]

I would like to work on this bug.
Can you please point to code.

Comment 16

[Julien Wajsberg [:julienw]]

hey Ankit, I just assign you to this bug. Please read comment 12 for more information, and you can come on IRC (irc.mozilla.org, #gaia-messaging) in case you have more questions.

Thanks!

Comment 17

[kumar rishav (:rishav_)]

julien Don't we have this feature already? IIRC i fixed this in some bug.

Comment 18

[kumar rishav (:rishav_)]

oh..yeah, is this bug differnt https://bugzilla.mozilla.org/show_bug.cgi?id=1053119 ?

Comment 19

[Julien Wajsberg [:julienw]]

In this bug we want to add the same "default" image than we have in Contacts, that is a green disk with the first letter of the first name inside.

We currently have the green disk (comes from bug 1003843), so the purpose of this bug would be to add the letter only.

I'm not sure we _really_ want it but the goal is also to have a patch so that we can try it for real and look whether we want it.

Comment 20

[kumar rishav (:rishav_)]

any update?

Comment 21

[kumar rishav (:rishav_)]

no updates from assignee.
setting to nobody.

Comment 22

[kumar rishav (:rishav_)]

vishnu, this may interest you :)

Comment 23

[Vishnu Teja [:ythej]]

rishav, I don't have a flame right now but will get in soon ! I will work on other bugs that can fix in using Mulet. This bug is interesting! I will work on this as soon I clear the stack of bugs remaining in my profile.

Thanks for searching bugs for me ! :)

Comment 26

[Ed Morley [:emorley]]

(In reply to Julien Wajsberg [:julienw] from bug 1222742 comment #2)
> Not really high priority from my pov. What do you think ? Would this be
> actually useful for you ?
> 
> *** This bug has been marked as a duplicate of bug 1080148 ***

Not urgent, however this is less about wanting to see the initial, and more that an empty circle looks "broken". It was also surprising to see that the contacts app implements this differently - I would have thought they'd share the same code for this.

In my case, when I first saw the empty circles, I didn't have any SMS threads from people that had pictures set, so had no context as to what they were actually for. To me, the circles actually looked like the blobs you get next to threads with an unread message count inside them, but that's obviously not the case.

Until the circles show initials (or something other thank being a plain blob), I think it would be better to not show them at all for messages where there is no image.

Comment 27

[kumar rishav (:rishav_)]

Hi JulienW,
As sorting doesn't matter for us OR we don't know sorting, It better to have a First letter from the receiver name (irrespective of what's there in contact app image) to maintain consistency across all the image.

I am not in favor of "not to show them at all for messages where there is no image" because of following reason:
a) Non saved contact also doesn't have contact images.
b) Adding more than one recipient also show images (with total number of recipient).

So,only when contact is not saved, then don't show image,
while in other case show image i.e:
1) If contact has image, then show that image, else show first letter in the default image.
2) if More than one recipient (irrespective of recipients contact are saved or not), show total number of recipient.

What do you say?

Thanks

Comment 28

[Julien Wajsberg [:julienw]]

I think jenny said everything in comment 11 already :) Let's implement this, it shouldn't be that difficult to do...

Comment 29

[Julien Wajsberg [:julienw]]

Hey Rishav, were you able to work on this? If not you might want to leave the bug unassigned :)

Comment 30

[kumar rishav (:rishav_)]

Sorry for the delay.I will resume from 18th Jan. If anyone wants to take this bug, feel free to unassigned it. Btw this was next bug to start with but caught with new year (will reach college by 17th Jan and résumé my bug)

Thanks

Comment 31

[GitHub Autolander Bot]

Attachment: [gaia] kumarrishav:Bug-1080148 > mozilla-b2g:master

Comment 32

[Julien Wajsberg [:julienw]]

Comment on attachment 8714368 [details] [review]
[gaia] kumarrishav:Bug-1080148 > mozilla-b2g:master

I just left a comment, it should be a quick fix for you

Comment 33

[kumar rishav (:rishav_)]

Comment on attachment 8714368 [details] [review]
[gaia] kumarrishav:Bug-1080148 > mozilla-b2g:master

fixed

Comment 34

[Julien Wajsberg [:julienw]]

Mass closing of Gaia::SMS bugs. End of an era :(

Comment 35

[Julien Wajsberg [:julienw]]

Mass closing of Gaia::SMS bugs. End of an era :(