Closed Bug 1080211 Opened 10 years ago Closed 10 years ago

Remove a bunch of Java code

Categories

(Firefox for Android Graveyard :: Toolbar, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 35

People

(Reporter: jrmuizel, Assigned: jrmuizel)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Remove a bunch of Java code (obsolete) — Splinter Review
The removes the mostly unused java based frames per second layer along related stuff.
Attachment #8502084 - Flags: review?(bugmail.mozilla)
Attached patch android-codeSplinter Review
Attachment #8502108 - Flags: review?(bugmail.mozilla)
Attachment #8502084 - Attachment is obsolete: true
Attachment #8502084 - Flags: review?(bugmail.mozilla)
The second version is more likely to build
Comment on attachment 8502108 [details] [diff] [review]
android-code

Review of attachment 8502108 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/gfx/LayerRenderer.java
@@ -396,1 @@
>                  mProfileRender = Log.isLoggable(PROFTAG, Log.DEBUG);

I wouldn't object to moving this mProfileRender assignment directly into the checkMonitoringEnabled callsite and getting rid of this function entirely. Certainly there's no need to spin up a new thread just to run this one line of code.
Attachment #8502108 - Flags: review?(bugmail.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/b7f4185d9a8e
Assignee: nobody → jmuizelaar
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.