Closed Bug 1080285 Opened 10 years ago Closed 10 years ago

Failing TC Gu tests, keyboard-test/unit/render_test.js

Categories

(Firefox OS Graveyard :: Gaia, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S6 (10oct)

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

TEST-UNEXPECTED-FAIL | null | [keyboard-test/unit/render_test.js] Renderer Draw Dimensions getHeight, 0 rows, portrait,  suggest, latin

https://taskcluster-artifacts.s3-us-west-2.amazonaws.com/hv89xBY1RvySSObdlVpgNg/0/public/logs/live_backing.log?AWSAccessKeyId=AKIAIZOQG4W6WG3PH3RQ&Expires=1412813104&Signature=o2TqG2Kn9pu6ylB4NeMyNlC2CuU%3D
Attached file Github pull request
Hey Rudy - Could you help me land this patch? You can emulate the failure on desktop by making firefox as small as possible. Mocking the dimensions seems to be a quick fix. Thanks!
Attachment #8502139 - Flags: review?(rlu)
Comment on attachment 8502139 [details] [review]
Github pull request

Looks good to me.
This is a known issue that we should have addressed earlier.

Kevin, thanks for your great help!
Attachment #8502139 - Flags: review?(rlu) → review+
In master: https://github.com/mozilla-b2g/gaia/commit/59e69597a05025d54e0cc45408c5b9cc4288d390
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [systemsfe]
Blocks: 1109925
No longer blocks: 1076681
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: