Closed Bug 1080335 Opened 10 years ago Closed 10 years ago

[EME] Hash device id with SHA256

Categories

(Core :: Audio/Video, defect)

Product:
Core
Component:
Audio/Video
Platform:
x86_64
Windows Vista
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox37 --- fixed
firefox38 --- fixed
firefox39 --- fixed

People

(Reporter: cpearce, Assigned: cpearce)

References

(Blocks 1 open bug)

Details

We should hash the node id added in bug 1060179 with SHA256 instead of SHA1, since SHA1 is considered not so great anymore.
I suggest using SHA-256 code from NaCl (http://nacl.cr.yp.to/). It's in the Public Domain and is pure C without external dependencies, so it should be easier to use statically in the CDM host executable than code entangled in NSS's internals/dependencies. (NaCl's build system might not be a good match for ours, so copying and pasting just the SHA-256 code as preprocessed by NaCl's build system is probably the way to go.)
There's no reason we can't use NSS's code like it was done in bug 1060179. In fact, I don't understand the comments about freebl. Did the reviewer miss the fact that the freebl code was being statically linked, and thus was not really freebl anymore?
Assignee: nobody → cpearce
These bugs are necessary for vouching and sandboxing a third-party CDM.
Blocks: eme-m2
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
No longer blocks: eme-m2
Mass update firefox-status to track EME uplift.
status-firefox37: --- → fixed
status-firefox38: --- → fixed
status-firefox39: --- → fixed
You need to log in before you can comment on or make changes to this bug.