1080335 - [EME] Hash device id with SHA256

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

We should hash the node id added in bug 1060179 with SHA256 instead of SHA1, since SHA1 is considered not so great anymore.

Comment 1

[Henri Sivonen (:hsivonen) (temporarily away from Bugzilla)]

I suggest using SHA-256 code from NaCl (http://nacl.cr.yp.to/). It's in the Public Domain and is pure C without external dependencies, so it should be easier to use statically in the CDM host executable than code entangled in NSS's internals/dependencies. (NaCl's build system might not be a good match for ours, so copying and pasting just the SHA-256 code as preprocessed by NaCl's build system is probably the way to go.)

Comment 2

[Mike Hommey [:glandium]]

There's no reason we can't use NSS's code like it was done in bug 1060179. In fact, I don't understand the comments about freebl. Did the reviewer miss the fact that the freebl code was being statically linked, and thus was not really freebl anymore?

Comment 3

[Chris Peterson [:cpeterson]]

These bugs are necessary for vouching and sandboxing a third-party CDM.

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Fixed by bug 1088488.

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Mass update firefox-status to track EME uplift.