Closed Bug 1080344 Opened 8 years ago Closed 8 years ago

Failing TC Gu test: keyboard-test/unit/alternatives_char_menu_test.js

Categories

(Firefox OS Graveyard :: Gaia, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S6 (10oct)

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
rudyl
: review+
Details | Review
Another bug about resolution.

6) [keyboard-test/unit/views/alternatives_char_menu_test.js] Views > AlternativesCharMenuView  > getMenuTarget() - 2 row case 2 row - the 4th element in the upper row:

https://taskcluster-artifacts.s3-us-west-2.amazonaws.com/4n7A_jLfT36t_m93Qu0QUg/0/public/unit_tests_b2g/debug.log?AWSAccessKeyId=AKIAIZOQG4W6WG3PH3RQ&Expires=1412831215&Signature=%2Bfi7%2FKW%2BxlMrKE9sgsqJjoczXZY%3D
Attached file Github pull request
Comment on attachment 8502254 [details] [review]
Github pull request

Hey Rudy - could you also look at this one? This test is giving us problems depending on the resolution as well. But we can address it by adjusting the coordinates based on the fake input bounding rectangle. What do you think?
Attachment #8502254 - Flags: review?(rlu)
Comment on attachment 8502254 [details] [review]
Github pull request

Should be good as well.
Thanks again.
Attachment #8502254 - Flags: review?(rlu) → review+
In master: https://github.com/mozilla-b2g/gaia/commit/43457be4f632499d4b1d41abe302663fa583abab
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S6 (10oct)
Blocks: 1109925
No longer blocks: 1076681
You need to log in before you can comment on or make changes to this bug.