1080357 - IME switching menu showing wrong current keyboard

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Input Mgmt, defect)

Description

[John Lu [:mnjul][Please NI or I'll miss]]

STR:
1. Enable a few keyboards, such as English, French, Spanish, Polish
2. Open an app and focus a textbox to bring p the keyboard. Suppose you're then at English keyboard
3. Switch to some other keyboard, say Spanish
4a. Pull down utility tray, click the IME switcher entry ("Built-in Keyboard: Español, Tap to switch input method") to bring up the IME switching menu, OR
4b. Long press the short label of the keyboard layout to bring up the IME switching menu

Actual results:
At step 4a or 4b, the IME switching menu indicates that English is the current keyboard, which is wrong.

Expected results:
At step 4a or 4b, the IME switching menu indicates the current keyboard correctly as Español.

Note: the IME switcher in the utility tray itself shows the current keyboard correctly. It's the menu that it launches that's wrong.

Comment 1

[John Lu [:mnjul][Please NI or I'll miss]]

Reverting bug 1048228 seems to fix the issue. Jan, could you take a look? Thanks!

Comment 2

[Jan Jongboom [:janjongboom] (inactive)]

Attachment: Patch

The problem here is that we save all settings in keyboard_helper whenever someone changes the current layout. This triggers settings listeners for layouts (for when you add new layout through Settings app), which resets the activeLayout to 0 for all groups (in input_layouts.js). The ImeMenu looks at that, sees 0 and selects English from there. This patch only updates the activelayout setting to get around that.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8502434 [details] [review]
Patch

Looking at this patch alone I wonder if we need to add some tests on this part.

Comment 4

[Jan Jongboom [:janjongboom] (inactive)]

It would need an integration test I think. Unit testing these event wired things is a pita.

Try is green https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=4166e4874940
Landed https://github.com/mozilla-b2g/gaia/commit/61a874ba48614f9e73cba4d758aac1451eaada04

Comment 5

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

set in‑testsuite? to indicate we would need an integration test to cover this.

Comment 6

[KTucker [:KTucker][Inactive 3/4/2016]]

Brogan, please verify that this issue is fixed.

Comment 7

[Brogan Zumwalt [Inactive]]

Issue verified fixed on Flame 2.2

Actual results: IME switching menus display active keyboard language correctly

Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141024040202
Gaia: d893a9b971a0f3ee48e5a57dca516837d92cf52b
Gecko: a5ee2769eb27
Gonk: 05aa7b98d3f891b334031dc710d48d0d6b82ec1d
Version: 36.0a1 (2.2 Master)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Blocking 2.2+ for all fixed regressions.