1080358 - error: ‘class js::jit::MacroAssembler’ has no member named ‘loadAsmJSHeapRegisterFromGlobalData’

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Octoploid]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:35.0) Gecko/20100101 Firefox/35.0
Build ID: 20141006154327

Steps to reproduce:

Try to build Firefox trunk on ppc64.


Actual results:

In file included from /home/trippels/moz-build-dir/js/src/Unified_cpp_js_src0.cpp:38:0:
/home/trippels/gecko-dev/js/src/asmjs/AsmJSValidate.cpp: In function ‘bool GenerateEntry({anonymous}::ModuleCompiler&, unsigned int)’:
/home/trippels/gecko-dev/js/src/asmjs/AsmJSValidate.cpp:7443:10: error: ‘class js::jit::MacroAssembler’ has no member named ‘loadAsmJSHeapRegisterFromGlobalData’
     masm.loadAsmJSHeapRegisterFromGlobalData();
          ^
/home/trippels/gecko-dev/js/src/asmjs/AsmJSValidate.cpp: In function ‘bool GenerateFFIInterpExit({anonymous}::ModuleCompiler&, const {anonymous}::ModuleCompiler::ExitDescriptor&, unsigned int, js::jit::Label*)’:
/home/trippels/gecko-dev/js/src/asmjs/AsmJSValidate.cpp:7704:10: error: ‘class js::jit::MacroAssembler’ has no member named ‘loadAsmJSHeapRegisterFromGlobalData’
     masm.loadAsmJSHeapRegisterFromGlobalData();
          ^
/home/trippels/gecko-dev/js/src/asmjs/AsmJSValidate.cpp: In function ‘bool GenerateFFIIonExit({anonymous}::ModuleCompiler&, const {anonymous}::ModuleCompiler::ExitDescriptor&, unsigned int, js::jit::Label*)’:
/home/trippels/gecko-dev/js/src/asmjs/AsmJSValidate.cpp:7920:10: error: ‘class js::jit::MacroAssembler’ has no member named ‘loadAsmJSHeapRegisterFromGlobalData’
     masm.loadAsmJSHeapRegisterFromGlobalData();
          ^
/home/trippels/gecko-dev/js/src/asmjs/AsmJSValidate.cpp:7768:14: warning: unused variable ‘globalDataOffset’ [-Wunused-variable]
     unsigned globalDataOffset = m.module().exitIndexToGlobalDataOffset(exitIndex);
              ^
In file included from /home/trippels/moz-build-dir/js/src/Unified_cpp_js_src0.cpp:38:0:
/home/trippels/gecko-dev/js/src/asmjs/AsmJSValidate.cpp: In function ‘bool GenerateSyncInterruptExit({anonymous}::ModuleCompiler&, js::jit::Label*)’:
/home/trippels/gecko-dev/js/src/asmjs/AsmJSValidate.cpp:8253:10: error: ‘class js::jit::MacroAssembler’ has no member named ‘loadAsmJSHeapRegisterFromGlobalData’
     masm.loadAsmJSHeapRegisterFromGlobalData();
          ^

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Add loadAsmJSHeapRegisterFromGlobalData to arch none

Allows to build arch=none locally.

Comment 2

[Luke Wagner [:luke]]

Comment on attachment 8502465 [details] [diff] [review]
Add loadAsmJSHeapRegisterFromGlobalData to arch none

Thanks!  I need to start remembering to add these...

Comment 3

[Benjamin Bouvier [:bbouvier] (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/28f0136d5ea9

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Backed out for mochitest-dt orange.
https://hg.mozilla.org/integration/mozilla-inbound/rev/299fd510e405

https://treeherder.mozilla.org/ui/logviewer.html#?job_id=2893452&repo=mozilla-inbound

Comment 5

[Ryan VanderMeulen [:RyanVM]]

This may have been bug 844457 after all. Please verify you're green on Try and then go ahead and re-land. Note that links to Try runs (if you've got them) in the bug can help avoid backouts like these in the future.

Comment 6

[Benjamin Bouvier [:bbouvier] (inactive)]

As said on IRC, this concerns non-tier1 platforms, so testing on Try would have been a waste of resources.

https://hg.mozilla.org/integration/mozilla-inbound/rev/85a0fa4ed244

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/85a0fa4ed244