1080377 - SettingsRequestManager xpcshell test disabled on b2g emulator debug

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:gerard-majax]

Attachment: try_ubuntu64_vm-b2g-emulator-debug_test-xpcshell-1-bm113-tests1-linux64-build87.txt.gz

00:04:09     INFO -  10-09 05:57:58.002 I/Gecko   (   44): [44] WARNING: 'NS_FAILED(rv)', file ../../../gecko/dom/indexedDB/ActorsParent.cpp, line 6582
00:04:09     INFO -  10-09 05:57:58.032 I/Gecko   (   44): [44] WARNING: 'NS_FAILED(rv)', file ../../../gecko/dom/indexedDB/ActorsParent.cpp, line 12877
00:04:09     INFO -  10-09 05:57:58.032 I/Gecko   (   44): [44] WARNING: Converting non-IndexedDB error code (0x80630001) to NS_ERROR_DOM_INDEXEDDB_UNKNOWN_ERR: file ../../../gecko/dom/indexedDB/ActorsParent.cpp, line 408
00:04:09  WARNING -  10-09 05:57:58.042 W/GeckoConsole(   44): [JavaScript Error: "IndexedDB UnknownErr: ActorsParent.cpp:414"]
00:04:09     INFO -  10-09 05:57:58.182 I/Gecko   ( 1950):

Comment 1

[:gerard-majax]

Attachment: Re-enable SettingsRequestManager xpcshell test

Comment 2

[:gerard-majax]

https://tbpl.mozilla.org/?tree=Try&rev=6be15c8de431

Comment 3

[:gerard-majax]

(In reply to Alexandre LISSY :gerard-majax from comment #2)
> https://tbpl.mozilla.org/?tree=Try&rev=6be15c8de431

(In reply to Alexandre LISSY :gerard-majax from comment #0)
> Created attachment 8502304 [details]
> try_ubuntu64_vm-b2g-emulator-debug_test-xpcshell-1-bm113-tests1-linux64-
> build87.txt.gz
> 
> 00:04:09     INFO -  10-09 05:57:58.002 I/Gecko   (   44): [44] WARNING:
> 'NS_FAILED(rv)', file ../../../gecko/dom/indexedDB/ActorsParent.cpp, line
> 6582
> 00:04:09     INFO -  10-09 05:57:58.032 I/Gecko   (   44): [44] WARNING:
> 'NS_FAILED(rv)', file ../../../gecko/dom/indexedDB/ActorsParent.cpp, line
> 12877
> 00:04:09     INFO -  10-09 05:57:58.032 I/Gecko   (   44): [44] WARNING:
> Converting non-IndexedDB error code (0x80630001) to
> NS_ERROR_DOM_INDEXEDDB_UNKNOWN_ERR: file
> ../../../gecko/dom/indexedDB/ActorsParent.cpp, line 408
> 00:04:09  WARNING -  10-09 05:57:58.042 W/GeckoConsole(   44): [JavaScript
> Error: "IndexedDB UnknownErr: ActorsParent.cpp:414"]
> 00:04:09     INFO -  10-09 05:57:58.182 I/Gecko   ( 1950):

This is still present in the failing runs:

> 07:31:12     INFO -  11-07 15:26:19.720 I/Gecko   ( 2039): {"action":"log","time":1415373979669,"thread":null,"pid":null,"source":"xpcshell/head.js","level":"INFO","message":"/builds/slave/test/build/tests/xpcshell/tests/dom/settings/tests/unit/test_settingsrequestmanager_messages.js | Starting test_get_empty"}
> 07:31:12     INFO -  11-07 15:26:19.820 I/Gecko   ( 2039):
> 07:31:12     INFO -  11-07 15:26:19.820 I/Gecko   ( 2039): {"action":"log","time":1415373979797,"thread":null,"pid":null,"source":"xpcshell/head.js","level":"INFO","message":"(xpcshell/head.js) | test test_get_empty pending (2)"}
> 07:31:12     INFO -  11-07 15:26:19.900 I/Gecko   ( 2039):
> 07:31:12     INFO -  11-07 15:26:19.900 I/Gecko   ( 2039): {"action":"log","time":1415373979877,"thread":null,"pid":null,"source":"xpcshell/head.js","level":"INFO","message":"(xpcshell/head.js) | test run_next_test 1 finished (2)"}
> 07:31:12     INFO -  11-07 15:26:21.860 I/Gecko   ( 2039): [2039] WARNING: 'NS_FAILED(rv)', file ../../../gecko/dom/indexedDB/ActorsParent.cpp, line 6599
> 07:31:12     INFO -  11-07 15:26:21.920 I/Gecko   ( 2039): [2039] WARNING: 'NS_FAILED(rv)', file ../../../gecko/dom/indexedDB/ActorsParent.cpp, line 12983
> 07:31:12     INFO -  11-07 15:26:21.920 I/Gecko   ( 2039): [2039] WARNING: Converting non-IndexedDB error code (0x80630001) to NS_ERROR_DOM_INDEXEDDB_UNKNOWN_ERR: file ../../../gecko/dom/indexedDB/ActorsParent.cpp, line 407
> 07:31:12  WARNING -  11-07 15:26:21.920 W/GeckoConsole( 2039): [JavaScript Error: "IndexedDB UnknownErr: ActorsParent.cpp:413"]
> 07:31:12     INFO -  11-07 15:26:33.361 I/Gecko   ( 1856): ++DOCSHELL 0x465efc00 == 2 [pid = 1856] [id = 2]
> 07:31:12     INFO -  11-07 15:26:33.391 I/Gecko   ( 1856): ++DOMWINDOW == 4 (0x443a7950) [pid = 1856] [serial = 4] [outer = 0x0]
> 07:31:12     INFO -  11-07 15:26:33.451 I/Gecko   ( 1856): ++DOCSHELL 0x465f0400 == 3 [pid = 1856] [id = 3]
> 07:31:12     INFO -  11-07 15:26:33.471 I/Gecko   ( 1856): ++DOMWINDOW == 5 (0x443a7b20) [pid = 1856] [serial = 5] [outer = 0x0]
> 07:31:12     INFO -  11-07 15:26:33.511 I/Gecko   ( 1856): ++DOCSHELL 0x465f0800 == 4 [pid = 1856] [id = 4]
> 07:31:12     INFO -  11-07 15:26:33.521 I/Gecko   ( 1856): ++DOMWINDOW == 6 (0x443a7cf0) [pid = 1856] [serial = 6] [outer = 0x0]

Would you have any idea on this ben?

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Not off the top of my head. I'll take a look.

Comment 5

[:gerard-majax]

https://tbpl.mozilla.org/?tree=Try&rev=6b90924ccf13

Comment 6

[:gerard-majax]

https://tbpl.mozilla.org/?tree=Try&rev=36daaca25161

Comment 7

[:gerard-majax]

(In reply to Alexandre LISSY :gerard-majax from comment #5)
> https://tbpl.mozilla.org/?tree=Try&rev=6b90924ccf13

Now that we have more useful output in settings, it looks like we have an indexedDB condition and that the test just do not properly handle this, hence the timeout.

Comment 8

[:gerard-majax]

(In reply to Alexandre LISSY :gerard-majax from comment #6)
> https://tbpl.mozilla.org/?tree=Try&rev=36daaca25161

This try should have error handlers, and does a |ok(false)|

Comment 9

[:gerard-majax]

https://tbpl.mozilla.org/?tree=Try&rev=f48568087335

Comment 10

[:gerard-majax]

(In reply to Alexandre LISSY :gerard-majax from comment #9)
> https://tbpl.mozilla.org/?tree=Try&rev=f48568087335

This try should have error handlers, and does a |ok(true)|

Comment 11

[:gerard-majax]

Attachment: Re-enable SettingsRequestManager xpcshell test

Comment 12

[:gerard-majax]

(In reply to Alexandre LISSY :gerard-majax from comment #10)
> (In reply to Alexandre LISSY :gerard-majax from comment #9)
> > https://tbpl.mozilla.org/?tree=Try&rev=f48568087335
> 
> This try should have error handlers, and does a |ok(true)|

And this one is green after 100 retriggers :)

Comment 13

[:gerard-majax]

So, ben, it looks like the IndexedDB error may just have triggered incomplete code path in the test; we were not handling the case of settings requests failing. So I'm unsure if there is any IndexedDB issue here.

Comment 14

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8541140 [details] [diff] [review]
Re-enable SettingsRequestManager xpcshell test

Review of attachment 8541140 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

Comment 15

[:gerard-majax]

See try in comment 12.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/fec64d57eebd

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fec64d57eebd

Comment 18

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Sounds like we're all good here.