1080382 - [NFC][KK][2.0] flame-kk.xml should use nfcd from 2.0 branch

Status: VERIFIED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Alison Shiue]

Attachment: NFC_issue.log

Based on v184, full flash latest 2.0 KK build
Gaia-Rev        94638b51a5a5d513e26247e9b207aa54e7bb0568
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/bc9e3fa37e63
Build-ID        20141008160201
Version         32.0

(*Note: This issue does not happen on v184 with KK gecko/gaia shallow flash.)

STR: 
1. Open a image (or URL, contacts)
2. Tap 2 phones together
3. Check the shrinking UI 
4. Swipt the shrinking UI 

Expect result:
Share image successfully

Actual resalt:
app screen disapper on shrinking and could not share image(or URL, contacts)

Comment 1

[Alison Shiue]

[Blocking Requested - why for this release]:
Basic function issue

Comment 2

[Jamin Liu [:jaliu][:Jamin]]

(In reply to Alison Shiue from comment #0)
> Created attachment 8502321 [details]
> NFC_issue.log
> 
> Based on v184, full flash latest 2.0 KK build
> Gaia-Rev        94638b51a5a5d513e26247e9b207aa54e7bb0568
> Gecko-Rev      
> https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/bc9e3fa37e63
> Build-ID        20141008160201
> Version         32.0
> 
> (*Note: This issue does not happen on v184 with KK gecko/gaia shallow flash.)
> 
> STR: 
> 1. Open a image (or URL, contacts)
> 2. Tap 2 phones together
> 3. Check the shrinking UI 
> 4. Swipt the shrinking UI 
> 
> Expect result:
> Share image successfully
> 
> Actual resalt:
> app screen disapper on shrinking and could not share image(or URL, contacts)

Thank you, Alison.

From my observe, if user try to send a photo via NFC, a notification "File count not be sent" would pop up immediately. At the same time, an error message "sendNDEF(hr) failed" can be found by using adb logcat to indicate that nfcPeer.sendNDEF(hr) failed.
P.S. The debug-flag of NFC have to be turned on.

In my experiment, the NFC sharing works fine if I flash v184 flame-kk image and replace gecko/gaia 2.0 by PVT shallow flash. Therefore, I think this issue is related to gonk layer.

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

The manifest for Flame-kk on 2.0 branch is using the nfcd on *master* branch.

https://github.com/mozilla-b2g/b2g-manifest/blob/v2.0/flame-kk.xml#L151

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Pull Request

Comment 5

[viral [:viralwang]]

Comment on attachment 8502411 [details] [review]
Pull Request

It should be a safe change to move master branch to v2.0.

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://github.com/mozilla-b2g/b2g-manifest/commit/97a7d4fe2e7a42e1cd86eea948591cc381a0e60c

Comment 7

[Alison Shiue]

Verified on
Gaia-Rev        21fc294d6c9b78997142153fc32c3175b4835a89
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/93530962cca3
Build-ID        20141013160201
Version         32.0