The AcceptCallButton component should manage its own logic, not via IncomingConversationView

RESOLVED WONTFIX

Status

P5
normal
RESOLVED WONTFIX
4 years ago
3 years ago

People

(Reporter: standard8, Unassigned)

Tracking

unspecified
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [tech-debt])

(Reporter)

Description

4 years ago
The AcceptCallButton is currently not managing its own logic, but is being passed a function from the IncomingConversationView (IncomingConversationView#_answerModeProps).

This makes it hard to unit test that items are working correctly, as the logic, tooltips and classes are spread across multiple components.

We should move the logic into AcceptCallButton, with the only props needed being:

- The default type of call (if video or not)
- A function to handle the action if the button is clicked.


This is split out from bug 1079128 where we discussed doing a unit test, but found it too difficult.

Updated

4 years ago
backlog: --- → Fx36+

Updated

4 years ago
backlog: Fx36+ → Fx37+

Updated

4 years ago
backlog: Fx37+ → Fx38?
(Reporter)

Updated

4 years ago
backlog: Fx38? → tech-debt
Priority: -- → P5
(Reporter)

Comment 1

3 years ago
We are currently reworking the Loop "user journey" (bug 1209713) and as part of this direct calls and contacts are being removed. Therefore closing direct call related bugs as wontfix.

Tracking id: directcallclosing
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.