1080387 - The AcceptCallButton component should manage its own logic, not via IncomingConversationView

Status: RESOLVED WONTFIX

(Hello (Loop) :: Client, defect, P5)

Description

[Mark Banner (:standard8)]

The AcceptCallButton is currently not managing its own logic, but is being passed a function from the IncomingConversationView (IncomingConversationView#_answerModeProps).

This makes it hard to unit test that items are working correctly, as the logic, tooltips and classes are spread across multiple components.

We should move the logic into AcceptCallButton, with the only props needed being:

- The default type of call (if video or not)
- A function to handle the action if the button is clicked.


This is split out from bug 1079128 where we discussed doing a unit test, but found it too difficult.

Comment 1

[Mark Banner (:standard8)]

We are currently reworking the Loop "user journey" (bug 1209713) and as part of this direct calls and contacts are being removed. Therefore closing direct call related bugs as wontfix.

Tracking id: directcallclosing