Closed Bug 1080395 Opened 5 years ago Closed 5 years ago

Crash reporter is only partially localized

Categories

(Toolkit :: Crash Reporting, defect)

x86
macOS
defect
Not set

Tracking

()

VERIFIED FIXED
mozilla35
Tracking Status
firefox35 --- verified

People

(Reporter: flod, Assigned: robert.strong.bugs)

References

Details

(Keywords: verifyme)

Attachments

(3 files, 2 obsolete files)

Firefox crashed this morning, and Crash Reporter it's a mess of mostly untranslated strings (2 strings are translated).

Last time Firefox crashed (a month ago), I didn't notice anything strange in the window.

Current build: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:35.0) Gecko/20100101 Firefox/35.0
Can you check if /Applications/FirefoxNightly.app/Contents/Resources/crashreporter.app/Contents/Resources/crashreporter.ini is localized for you?

I confess, I didn't pay attention to the UI in my last few crashes.
(related to bug 1047584? I see at least a couple of Crash Reporter bugs depending from that)

/Applications/FirefoxNightly.app/Contents/Resources/crashreporter.app/Contents/Resources/crashreporter.ini is fully localized.
If someone could point me in the general direction of where the localization happens, I'd be happy to take a look.
(In reply to Francesco Lodolo [:flod] from comment #2)
> (related to bug 1047584? I see at least a couple of Crash Reporter bugs
> depending from that)
> 
> /Applications/FirefoxNightly.app/Contents/Resources/crashreporter.app/
> Contents/Resources/crashreporter.ini is fully localized.

I'm assuming (hoping) this was meant to be:
/Applications/FirefoxNightly.app/Contents/MacOS/crashreporter.app/Contents/Resources/crashreporter.ini

(Note the "MacOS" instead of "Resources" in the path)
Flags: needinfo?(francesco.lodolo)
There's a crashreporter.app in both MacOS and Resources.

The one in Resources has a localized crashreporter.ini
/Applications/FirefoxNightly.app/Contents/Resources/crashreporter.app/Contents/Resources/crashreporter.ini

The one in MacOS has another crashreporter.ini which is completely in English
/Applications/FirefoxNightly.app/Contents/MacOS/crashreporter.app/Contents/Resources/crashreporter.ini
Flags: needinfo?(francesco.lodolo)
Okay, I think we've figured out what's going on. $(FINAL_TARGET) is currently pointing to Contents/Resources[1] but should point to Contents/MacOS. This makes it appear as if there was an additional crashreporter.app under FirefoxNightly.app/Contents/Resources. However, through inspection of the package it can be seen that there's actually only a localized crashreporter.ini under crashreporter.app/Contents/Resources. There are no binaries or other files in this .app bundle, hence it's not a valid bundle.

[1] http://mxr.mozilla.org/mozilla-central/source/toolkit/locales/Makefile.in#39
Attached patch patch rev1 (obsolete) — Splinter Review
Assignee: nobody → robert.strong.bugs
Status: NEW → ASSIGNED
I'm going to verify the path does the right thing when crash reporter is disabled before requesting review.
I verified that everything works with packaging and l10n repacks with crash reporter enabled and disabled.
(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #8)
> Created attachment 8502922 [details]
> screenshot with patch (Italian build)

For those curious, the truncated checkbox is bug 528800.
Attachment #8502927 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/3389b00c83bc
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Landed on aurora in the Mac V2 signing combined patch in bug 1047584
Keywords: verifyme
Tested on a few l10n builds that the crashreporter is localized (zh-TW, ko, pt-BR, de, es-ES, fr, ja, pl, ru) using latest Aurora/Developer Edition on Mac OS X 10.9.5.
Status: RESOLVED → VERIFIED
Depends on: 1115892
You need to log in before you can comment on or make changes to this bug.