Crash reporter is only partially localized

VERIFIED FIXED in Firefox 35

Status

()

Toolkit
Crash Reporting
VERIFIED FIXED
4 years ago
3 years ago

People

(Reporter: flod, Assigned: rstrong)

Tracking

({verifyme})

unspecified
mozilla35
x86
Mac OS X
verifyme
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox35 verified)

Details

Attachments

(3 attachments, 2 obsolete attachments)

(Reporter)

Description

4 years ago
Created attachment 8502336 [details]
Screenshot of crash reporter (Italian build)

Firefox crashed this morning, and Crash Reporter it's a mess of mostly untranslated strings (2 strings are translated).

Last time Firefox crashed (a month ago), I didn't notice anything strange in the window.

Current build: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:35.0) Gecko/20100101 Firefox/35.0

Comment 1

4 years ago
Can you check if /Applications/FirefoxNightly.app/Contents/Resources/crashreporter.app/Contents/Resources/crashreporter.ini is localized for you?

I confess, I didn't pay attention to the UI in my last few crashes.
(Reporter)

Comment 2

4 years ago
(related to bug 1047584? I see at least a couple of Crash Reporter bugs depending from that)

/Applications/FirefoxNightly.app/Contents/Resources/crashreporter.app/Contents/Resources/crashreporter.ini is fully localized.
If someone could point me in the general direction of where the localization happens, I'd be happy to take a look.
(In reply to Francesco Lodolo [:flod] from comment #2)
> (related to bug 1047584? I see at least a couple of Crash Reporter bugs
> depending from that)
> 
> /Applications/FirefoxNightly.app/Contents/Resources/crashreporter.app/
> Contents/Resources/crashreporter.ini is fully localized.

I'm assuming (hoping) this was meant to be:
/Applications/FirefoxNightly.app/Contents/MacOS/crashreporter.app/Contents/Resources/crashreporter.ini

(Note the "MacOS" instead of "Resources" in the path)
Flags: needinfo?(francesco.lodolo)
(Reporter)

Comment 5

4 years ago
There's a crashreporter.app in both MacOS and Resources.

The one in Resources has a localized crashreporter.ini
/Applications/FirefoxNightly.app/Contents/Resources/crashreporter.app/Contents/Resources/crashreporter.ini

The one in MacOS has another crashreporter.ini which is completely in English
/Applications/FirefoxNightly.app/Contents/MacOS/crashreporter.app/Contents/Resources/crashreporter.ini
Flags: needinfo?(francesco.lodolo)
Okay, I think we've figured out what's going on. $(FINAL_TARGET) is currently pointing to Contents/Resources[1] but should point to Contents/MacOS. This makes it appear as if there was an additional crashreporter.app under FirefoxNightly.app/Contents/Resources. However, through inspection of the package it can be seen that there's actually only a localized crashreporter.ini under crashreporter.app/Contents/Resources. There are no binaries or other files in this .app bundle, hence it's not a valid bundle.

[1] http://mxr.mozilla.org/mozilla-central/source/toolkit/locales/Makefile.in#39
Created attachment 8502898 [details] [diff] [review]
patch rev1
Assignee: nobody → robert.strong.bugs
Status: NEW → ASSIGNED
Created attachment 8502922 [details]
screenshot with patch (Italian build)
Attachment #8502898 - Attachment is obsolete: true
I'm going to verify the path does the right thing when crash reporter is disabled before requesting review.
Blocks: 1047584
No longer blocks: 928397
Created attachment 8502927 [details] [diff] [review]
patch - fix indentation
Attachment #8502925 - Attachment is obsolete: true
Attachment #8502927 - Flags: review?(ted)
I verified that everything works with packaging and l10n repacks with crash reporter enabled and disabled.
(Reporter)

Comment 13

4 years ago
(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #8)
> Created attachment 8502922 [details]
> screenshot with patch (Italian build)

For those curious, the truncated checkbox is bug 528800.
Attachment #8502927 - Flags: review?(ted) → review+
Pushed to mozilla-inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/3389b00c83bc
Target Milestone: --- → mozilla35
https://hg.mozilla.org/mozilla-central/rev/3389b00c83bc
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Landed on aurora in the Mac V2 signing combined patch in bug 1047584
status-firefox35: --- → fixed
Keywords: verifyme
Tested on a few l10n builds that the crashreporter is localized (zh-TW, ko, pt-BR, de, es-ES, fr, ja, pl, ru) using latest Aurora/Developer Edition on Mac OS X 10.9.5.
Status: RESOLVED → VERIFIED
status-firefox35: fixed → verified

Updated

3 years ago
Depends on: 1115892
You need to log in before you can comment on or make changes to this bug.