Closed
Bug 1080476
Opened 11 years ago
Closed 11 years ago
Upgrade to JSX 0.11.2
Categories
(Hello (Loop) :: Client, defect)
Hello (Loop)
Client
Tracking
(firefox35 fixed)
RESOLVED
FIXED
mozilla35
| Tracking | Status | |
|---|---|---|
| firefox35 | --- | fixed |
People
(Reporter: andreio, Unassigned)
Details
Attachments
(1 file)
|
220.49 KB,
patch
|
mikedeboer
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10) AppleWebKit/600.1.25 (KHTML, like Gecko) Version/8.0 Safari/600.1.25
Steps to reproduce:
Update to latest react-tools. As of now 0.11.2
Run ./build-jsx
It uses a strict equality to check for the version
Actual results:
Error saying I need react-tools 0.11.1
Expected results:
It should have compiled my jsx sources
Component: Untriaged → General
Product: Firefox → Loop
QA Contact: anthony.s.hughes
|
||
Comment 1•11 years ago
|
||
We created it as a strict check because we were seeing whitespace differences across different versions, and didn't want to confuse the diffs too much with the extra whitespace info.
Status: UNCONFIRMED → NEW
Component: General → Client
Ever confirmed: true
Summary: JSX build script shouldn't use strict equality check → Upgrade to JSX 0.11.2
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #8503006 -
Flags: review?(mdeboer)
|
||
Updated•11 years ago
|
Assignee: nobody → nperriault
Status: NEW → ASSIGNED
OS: Mac OS X → All
Hardware: x86 → All
|
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8503006 [details] [diff] [review]
Upgrade React to 0.11.2.
Review of attachment 8503006 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM. Thanks!
Attachment #8503006 -
Flags: review?(mdeboer) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Keywords: checkin-needed
|
||
Comment 5•11 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
|
|
||
Comment 6•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla35
status-firefox35:
--- → fixed
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•