1080529 - Remove maemo support from product details

Status: RESOLVED FIXED

(www.mozilla.org :: Product Details, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

Attachment: remove-mameo-support.diff

This patch remove some old code related to maemo support.

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: remove-mameo-support-example.diff

As example of the export json.

Comment 2

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8502462 [details] [diff] [review]
remove-mameo-support.diff

Review of attachment 8502462 [details] [diff] [review]:
-----------------------------------------------------------------

Change looks fine to me but I would wait for review from pmac or jmize in order for to have feedback from someone who knows Bedrock and can comment on any potential impact.

::: mobileDetails.class.php
@@ -19,4 @@
>          const android = 'android';
> -        const windows = 'win32';
> -        const mac = 'mac';
> -        const linux = 'linux-i686';

I see you're doing more platform cleanup than just maemo.

Comment 3

[Paul [:pmac] McLanahan]

This is fine as far as bedrock is concerned. I can't speak to any other project, but we're only using the "version", "alpha_version" and "beta_version" key values in bedrock.

Comment 4

[Sylvestre Ledru [:Sylvestre]]

thanks

merged:
http://viewvc.svn.mozilla.org/vc?view=revision&revision=133152
http://viewvc.svn.mozilla.org/vc?view=revision&revision=133155