Closed Bug 1080530 Opened 10 years ago Closed 10 years ago

triggerfirstrun should not depend on net connection

Categories

(Firefox OS Graveyard :: Gaia::Search, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Search
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.1 S6 (10oct)

People

(Reporter: daleharvey, Assigned: daleharvey)

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

https://github.com/mozilla-b2g/gaia/pull/25004
46 bytes, text/x-github-pull-request
kgrandon
: review+
Details | Review 
Right now the search notification only shows when there are results, by default these results come from e.me and depend on a net connection, this means tests that use triggerfirstrun fail when offline
Assignee: nobody → dale

        Attachment #8502609 -
        Flags: review?(kgrandon)

    
    

    
  
Comment on attachment 8502609 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/25004

Looks good to me. Thanks!

        Attachment #8502609 -
        Flags: review?(kgrandon) → review+

    
    

    
  
Switched it to null

https://github.com/mozilla-b2g/gaia/commit/f4451c52a0947a561abc0b1d42a39e3068768ad8
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [systemsfe]
Target Milestone: --- → 2.1 S6 (10oct)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: