Closed
Bug 1080530
Opened 10 years ago
Closed 10 years ago
triggerfirstrun should not depend on net connection
Categories
(Firefox OS Graveyard :: Gaia::Search, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S6 (10oct)
People
(Reporter: daleharvey, Assigned: daleharvey)
Details
(Whiteboard: [systemsfe])
Attachments
(1 file)
Right now the search notification only shows when there are results, by default these results come from e.me and depend on a net connection, this means tests that use triggerfirstrun fail when offline
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → dale
|
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8502609 -
Flags: review?(kgrandon)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8502609 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/25004
Looks good to me. Thanks!
Attachment #8502609 -
Flags: review?(kgrandon) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Switched it to null
https://github.com/mozilla-b2g/gaia/commit/f4451c52a0947a561abc0b1d42a39e3068768ad8
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Updated•10 years ago
|
Whiteboard: [systemsfe]
Target Milestone: --- → 2.1 S6 (10oct)
You need to log in
before you can comment on or make changes to this bug.
Description
•