Closed Bug 1080530 Opened 5 years ago Closed 5 years ago

triggerfirstrun should not depend on net connection

Categories

(Firefox OS Graveyard :: Gaia::Search, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S6 (10oct)

People

(Reporter: daleharvey, Assigned: daleharvey)

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

Right now the search notification only shows when there are results, by default these results come from e.me and depend on a net connection, this means tests that use triggerfirstrun fail when offline
Assignee: nobody → dale
Attachment #8502609 - Flags: review?(kgrandon)
Comment on attachment 8502609 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/25004

Looks good to me. Thanks!
Attachment #8502609 - Flags: review?(kgrandon) → review+
Switched it to null

https://github.com/mozilla-b2g/gaia/commit/f4451c52a0947a561abc0b1d42a39e3068768ad8
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [systemsfe]
Target Milestone: --- → 2.1 S6 (10oct)
You need to log in before you can comment on or make changes to this bug.