1080625 - [Usage][Cost Control] Restore animation for settings and data limit input screens.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Salvador de la Puente González [:salva]]

STR:
 1. Open Usage application.
 2. Tap on the gear to show settings.

Expected:
  The screen shows appears from bottom to top.

Actual:
  The screen simply appears.

The same happens when tapping on the limit in settings.

Comment 1

[Salvador de la Puente González [:salva]]

Regression is caused by bug 1075151 patch. My fault. As it's a blocker and it seems to solve the problem and given the user impact is not very high, instead of back-out, providing a new patch and asking for approval.

Comment 2

[Salvador de la Puente González [:salva]]

Attachment: Restoring view transitions while preventing wizard steps to animate.

You were right about this. It's not trivial to simply remove the transition for wizard steps without removing the transitions for other views.

Comment 3

[Salvador de la Puente González [:salva]]

Comment on attachment 8502538 [details] [review]
Restoring view transitions while preventing wizard steps to animate.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 1075151
[User impact] if declined: low
[Testing completed]: just CSS changes
[Risk to taking this patch] (and alternatives if risky): very low (just test bug 1075151 is not reproduced again. It does not happen for me at least).
[String changes made]: no

Comment 4

[Marina Rodríguez [:mai]]

Comment on attachment 8502538 [details] [review]
Restoring view transitions while preventing wizard steps to animate.

Works fine.
Thanks

Comment 5

[Salvador de la Puente González [:salva]]

master: 1036b544b7e102592bd9fab95cd9317329ac1293

Comment 6

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/9755d24b2ce2af38bb5ff54f9e08f89dce2d9384