1080661 - The count of shared URLs should be increased only once per generated URL

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[:Paolo Amadini]

Currently, the count of shared URLs is increased every time the "copy" or "email" buttons are used, or the link is copied manually. This, however, should only happen once per generated URL, even if different ways of sharing are used.

Comment 1

[:Paolo Amadini]

Attachment: The patch

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=572fd15ad4f2

In addition to automated unit testing, manual testing should verify that when a new URL is generated and shared after the first one, the shared count is increased.

I kept the patch simple to facilitate uplift, so this scenario isn't unit-tested, since it is difficult to reach the internal code that resets the flag.

Comment 2

[Matthew N. [:MattN]]

Comment on attachment 8502587 [details] [diff] [review]
The patch

Review of attachment 8502587 [details] [diff] [review]:
-----------------------------------------------------------------

The fix seems reasonable.

(In reply to :Paolo Amadini from comment #1)
> I kept the patch simple to facilitate uplift, so this scenario isn't
> unit-tested, since it is difficult to reach the internal code that resets
> the flag.

This is unfortunate as it seems like something fairly easy to break.

Comment 3

[:Paolo Amadini]

(In reply to Matthew N. [:MattN] (behind on reviews - focused on Loop) from comment #2)
> (In reply to :Paolo Amadini from comment #1)
> > I kept the patch simple to facilitate uplift, so this scenario isn't
> > unit-tested, since it is difficult to reach the internal code that resets
> > the flag.
> 
> This is unfortunate as it seems like something fairly easy to break.

I agree. We should have a recurring manual test on file for now, and I filed bug 1080732 about adding the automated test.

Comment 4

[:Paolo Amadini]

https://hg.mozilla.org/integration/fx-team/rev/86abd23340f0

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/86abd23340f0

Comment 6

[Maire Reavy [:mreavy]]

Hi Pauly, This should fix the bug you found yesterday in bug 1015988.  Can you verify?  Thanks!

Comment 7

[Paul Silaghi, QA [:pauly]]

Verified fixed 35.0a1 (2014-10-10) Win 7, Ubuntu 13.04, OS X 10.9.5

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1a999d18d96b

Comment 9

[Paul Silaghi, QA [:pauly]]

Verified fixed FF 34b1 Win 7