1080771 - Remove phone number highlighting code

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Doug Sherk (:drs) (inactive)]

The call info page in the Dialer currently highlights phone numbers when coming from the call log item associated with a contact.

In bug 1070050, we decided to remove the highlighting code for the phone number buttons in the Contacts app, since the call info page already has this. The code for this is shared in ContactsButtons, but we should move it to only the dialer, and remove the isMissedCall URL GET parameter from the activity that the Contacts app receives.

Comment 1

[Fernando Campo (:fcampo)]

Attachment: Link to PR

Comment 2

[Jose Manuel Cantera]

Comment on attachment 8506854 [details] [review]
Link to PR

r=me for the contacts part.

requiring review from Doug for the dialer part and the overall verification of the proposed patch

thanks Fernando

Comment 3

[Fernando Campo (:fcampo)]

Integration tests from verticalhome (not related) failing, I re-launched it but it's taking more time than expected.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/aad8dfc886c979ff1e45413936a4119896260cc2

Comment 5

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on latest nightly build of Flame v2.2.

STR:
1. There is a contact with several numbers.
2. Make a miss call log using a number of the contact.
3. Long tap the miss call log and go to call information-> contact details

Actual results: The highlighting for the phone number button in the Contacts app is removed as expected.
See attachment: verified_Flame_v2.2.3gp
Reproduce rate: 0/10


Device: Flame v2.2 (Verified) 
Build ID               20150716162504
Gaia Revision          e1e6317f17a840b19af9dbb25f5a771d8d9fa161
Gaia Date              2015-07-15 21:05:11
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/418b2388edb0
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150716.195810
Firmware Date          Thu Jul 16 19:58:22 EDT 2015
Bootloader             L1TC000118D0

Comment 6

[Shally Li（leave from Mozilla）]

Attachment: verified_Flame_v2.2.3gp