Closed Bug 1080787 Opened 5 years ago Closed 5 years ago

Enable customizableUI tests in e10s

Categories

(Firefox :: Toolbars and Customization, defect)

defect
Not set
Points:
5

Tracking

()

RESOLVED FIXED
Firefox 36
Iteration:
36.2
Tracking Status
e10s + ---

People

(Reporter: mossop, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Currently they are completely disabled but many of them appear to work and there are probably common problems for the ones that don't. Enable the ones that work and either fix or file specific bugs on the ones that don't.
Flags: qe-verify-
Flags: firefox-backlog+
Points: --- → 5
Taking, as everything else I'm doing is waiting for review/feedback/needinfo.
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Iteration: --- → 36.1
Flags: needinfo?(mmucci)
Flags: in-testsuite+
Added to IT 36.1
Flags: needinfo?(mmucci)
(In reply to :Gijs Kruitbosch from comment #2)
> remote:  
> https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=acd27db21f32

I was misled by trychooser (bug 1087382) and thought this still only ran on Linux, so I'll need to rerun this against OS X and Windows. Locally on OS X, this set passed. It seems to do on Linux, too, although there's a failure in some panorama test (?!) which isn't filed yet... retriggering at the moment to see if that's intermittent or what.

I'll look at the 3 tests the patch disabled later today or tomorrow to see what my odds of fixing them immediately are.
Depends on: 1088710
Depends on: 1088714
remote:   https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=3cade16e2101
I'll need to look in more detail at the searchbar_in_panel thing, I'll file a bug on that either late tonight or when I get back on Monday.
Attachment #8511092 - Flags: review?(mconley)
Comment on attachment 8511092 [details] [diff] [review]
enable customizableui tests under e10s,

Review of attachment 8511092 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Gijs!

::: browser/components/customizableui/test/browser.ini
@@ +33,5 @@
>  [browser_909779_overflow_toolbars_new_window.js]
>  skip-if = os == "linux"
>  
>  [browser_901207_searchbar_in_panel.js]
> +skip-if = e10s

A reminder to file a bug for this.

@@ +104,2 @@
>  [browser_967000_button_feeds.js]
> +skip-if = buildapp == 'mulet'

[DEFAULT] already makes us skip if buildapp == mulet, so we can probably remove this line.

@@ +127,5 @@
>  [browser_984455_bookmarks_items_reparenting.js]
>  skip-if = os == "linux"
>  
>  [browser_985815_propagate_setToolbarVisibility.js]
> +skip-if = e10s

A reminder to file a bug for this as well.
Attachment #8511092 - Flags: review?(mconley) → review+
Iteration: 36.1 → 36.2
Depends on: 1090635
Depends on: 1090656
https://hg.mozilla.org/mozilla-central/rev/caa95b342316
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Depends on: 1091561
You need to log in before you can comment on or make changes to this bug.