1080787 - Enable customizableUI tests in e10s

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Dave Townsend [:mossop]]

Currently they are completely disabled but many of them appear to work and there are probably common problems for the ones that don't. Enable the ones that work and either fix or file specific bugs on the ones that don't.

Comment 1

[:Gijs (he/him)]

Taking, as everything else I'm doing is waiting for review/feedback/needinfo.

Comment 2

[:Gijs (he/him)]

remote:   https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=acd27db21f32

Comment 3

[Marco Mucci [:MarcoM]]

Added to IT 36.1

Comment 4

[:Gijs (he/him)]

(In reply to :Gijs Kruitbosch from comment #2)
> remote:  
> https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=acd27db21f32

I was misled by trychooser (bug 1087382) and thought this still only ran on Linux, so I'll need to rerun this against OS X and Windows. Locally on OS X, this set passed. It seems to do on Linux, too, although there's a failure in some panorama test (?!) which isn't filed yet... retriggering at the moment to see if that's intermittent or what.

I'll look at the 3 tests the patch disabled later today or tomorrow to see what my odds of fixing them immediately are.

Comment 5

[:Gijs (he/him)]

Windows and mac trypush:

remote:   https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=c1c4c67572a1

Comment 6

[:Gijs (he/him)]

Attachment: enable customizableui tests under e10s,

remote:   https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=3cade16e2101
I'll need to look in more detail at the searchbar_in_panel thing, I'll file a bug on that either late tonight or when I get back on Monday.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8511092 [details] [diff] [review]
enable customizableui tests under e10s,

Review of attachment 8511092 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Gijs!

::: browser/components/customizableui/test/browser.ini
@@ +33,5 @@
>  [browser_909779_overflow_toolbars_new_window.js]
>  skip-if = os == "linux"
>  
>  [browser_901207_searchbar_in_panel.js]
> +skip-if = e10s

A reminder to file a bug for this.

@@ +104,2 @@
>  [browser_967000_button_feeds.js]
> +skip-if = buildapp == 'mulet'

[DEFAULT] already makes us skip if buildapp == mulet, so we can probably remove this line.

@@ +127,5 @@
>  [browser_984455_bookmarks_items_reparenting.js]
>  skip-if = os == "linux"
>  
>  [browser_985815_propagate_setToolbarVisibility.js]
> +skip-if = e10s

A reminder to file a bug for this as well.

Comment 8

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/integration/fx-team/rev/caa95b342316

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/caa95b342316