Update start.mozilla.org from https://github.com/mozilla/fx36start

RESOLVED FIXED

Status

Infrastructure & Operations Graveyard
WebOps: Product Delivery
RESOLVED FIXED
4 years ago
2 years ago

People

(Reporter: jpetto, Assigned: cturra)

Tracking

Details

(Whiteboard: [kanban:https://kanbanize.com/ctrl_board/4/1706] [fxgrowth])

(Reporter)

Description

4 years ago
We recently updated the index.html template to include Google Analytics on the search and modal/overlay actions. Can these changes be pushed to staging for testing?

After we get a thumbs-up from :garethc, we can push to production.

Thanks!

Updated

4 years ago
Whiteboard: [kanban:https://kanbanize.com/ctrl_board/4/1523]
(Reporter)

Updated

4 years ago
Whiteboard: [kanban:https://kanbanize.com/ctrl_board/4/1523] → [kanban:https://kanbanize.com/ctrl_board/4/1523] [fxgrowth]
(Assignee)

Updated

4 years ago
Assignee: server-ops-webops → cturra
(Assignee)

Comment 1

4 years ago
changes pushed to stage as requested.

  http://start.allizom.org/en-US/


pls let me know if you're happy with this going to prod.
Flags: needinfo?(jon)
(Reporter)

Comment 2

4 years ago
Hmm, I'm not seeing the latest changes on stage.
Flags: needinfo?(jon)
(Assignee)

Comment 3

4 years ago
i just double checked your recent github commit and do see the changes on stage. here is an example from the page i am looking at right now...

  <form action="http://google.com/search" name="f" id="search-form">


is it possible you're getting a browser cache hit?
(Assignee)

Comment 4

4 years ago
also.. 

$ curl -s http://start.allizom.org/en-US/js/ffx36.js | head -10
var FFX36 = window.FFX36 || {};

FFX36.Common = (function() {
	function _init() {
		var $sf = $('#sf');
		var $modal, $shade;

		$sf.focus();

		if (_is_upgradable()) {
(Reporter)

Comment 5

4 years ago
Whoa, weird. I just force refreshed for a second time and now I see the latest code on stage. I think I'm having a bad day™.

:garethc - Can you test stage and make sure GA is behaving as expected?

Thanks :cturra!
Flags: needinfo?(garethcull.bugs)

Comment 6

4 years ago
(In reply to Jon Petto [:jpetto] from comment #5)
> Whoa, weird. I just force refreshed for a second time and now I see the
> latest code on stage. I think I'm having a bad day™.
> 
> :garethc - Can you test stage and make sure GA is behaving as expected?
> 
> Thanks :cturra!

:jpetto: I can see the submit events on stage, but no click events on "google search" button. Basically, if I search with clicking the search button, no event is sent.
Flags: needinfo?(garethcull.bugs) → needinfo?(jon)
(Reporter)

Comment 7

4 years ago
:cmore - Hm, odd. Using HttpFox on stage, I see the following request sent when entering a search term and pushing the enter key:

GET /__utm.gif?utmwv=5.6.0&utms=3&utmn=524401004&utmhn=start.allizom.org&utmt=event&utme=5(start.mozilla.org%20Interactions*Submit*Google%20Search)&utmcs=UTF-8&utmsr=1920x1080&utmvp=1483x832&utmsc=24-bit&utmul=en-us&utmje=0&utmfl=15.0%20r0&utmdt=Mozilla%20Firefox%20Start%20Page&utmhid=855780603&utmr=-&utmp=%2Fen-US%2F&utmht=1413380018592&utmac=UA-35433268-25&utmcc=__utma%3D12264054.1089578168.1411769692.1412887724.1413379978.4%3B%2B__utmz%3D12264054.1411769692.1.1.utmcsr%3D(direct)%7Cutmccn%3D(direct)%7Cutmcmd%3D(none)%3B&utmjid=&utmu=6AAAAAAAAAAAAAAAAAAAAAAE~ HTTP/1.1

I see the below (identical?) request when entering a search term and clicking the "Google Search" button:

GET /__utm.gif?utmwv=5.6.0&utms=6&utmn=837090951&utmhn=start.allizom.org&utmt=event&utme=5(start.mozilla.org%20Interactions*Submit*Google%20Search)&utmcs=UTF-8&utmsr=1920x1080&utmvp=1483x832&utmsc=24-bit&utmul=en-us&utmje=0&utmfl=15.0%20r0&utmdt=Mozilla%20Firefox%20Start%20Page&utmhid=374180187&utmr=-&utmp=%2Fen-US%2F&utmht=1413380097941&utmac=UA-35433268-25&utmcc=__utma%3D12264054.1089578168.1411769692.1412887724.1413379978.4%3B%2B__utmz%3D12264054.1411769692.1.1.utmcsr%3D(direct)%7Cutmccn%3D(direct)%7Cutmcmd%3D(none)%3B&utmjid=&utmu=6AAAAAAAAAAAAAAAAAAAAAAE~ HTTP/1.1

Also, using the debugger in dev tools, my break point (on line 41 of ffx36.js) on the GA call is hit both when pressing enter and clicking submit.

Any ideas?
Flags: needinfo?(jon)

Comment 8

4 years ago
Ok, I am seeing events for both hitting enter and clicking the button. The confusion was that if you searched, clicked back, searched for something else, it wouldn't fire off additional events. The events appear to only get sent once per visit to the page. 

Can you confirm you see the same thing?
(Reporter)

Comment 9

4 years ago
We are still seeing a bit of odd JS behavior (mentioned in comment 8), but it's *only* in Release and Beta. Other channels (Aurora, Nightly) and browsers (Chrome, Safari, IE) do not exhibit the odd behavior.

We aren't blocked on the above, though we will likely continue to test and diagnose next week.

:cturra - Can we do a production push? Thanks!
Flags: needinfo?(cturra)

Updated

4 years ago
Whiteboard: [kanban:https://kanbanize.com/ctrl_board/4/1523] [fxgrowth] → [fxgrowth]

Updated

4 years ago
Whiteboard: [fxgrowth] → [kanban:https://kanbanize.com/ctrl_board/4/1706] [fxgrowth]
(Assignee)

Comment 10

4 years ago
push to prod compete. sorry for the delay here, your last comment got a lost in my bugmail :(
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Flags: needinfo?(cturra)
Resolution: --- → FIXED
Product: Infrastructure & Operations → Infrastructure & Operations Graveyard
You need to log in before you can comment on or make changes to this bug.