Closed
Bug 1080867
Opened 10 years ago
Closed 10 years ago
RemoteBlob->RemoteBlobImpl broke threadsafety assumptions
Categories
(Core :: DOM: Content Processes, defect)
Core
DOM: Content Processes
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: bent.mozilla, Assigned: bent.mozilla)
Details
Attachments
(1 file)
12.17 KB,
patch
|
khuey
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
RemoteBlob had some baked-in assumptions about which thread DOM methods were called on. Now that everything is RemoteBlobImpl those assumptions don't hold and so we have threadsafety problems.
Attachment #8502793 -
Flags: review?(khuey)
Attachment #8502793 -
Flags: review?(khuey) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 1•10 years ago
|
||
I was only able to find one try push for this and it looked like it had bustage. Please link to a green Try run when requesting checkin.
Keywords: checkin-needed
Assignee | ||
Comment 2•10 years ago
|
||
Sorry, it was buried in here: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=f7017c8f2012
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ebcb03acce64
https://hg.mozilla.org/mozilla-central/rev/ebcb03acce64
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8502793 [details] [diff] [review] Fix threadsafety, v1 Approval Request Comment [Feature/regressing bug #]: 876683 [User impact if declined]: Some threaded edge cases may crash [Describe test coverage new/current, TBPL]: trunk [Risks and why]: This patch is small, simple, and protects against edge cases that we may not ever exercise. [String/UUID change made/needed]: None
Attachment #8502793 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 6•10 years ago
|
||
(In reply to ben turner from comment #5) > Approval Request Comment It would also make uplifting bug 1079546 easier!
Updated•10 years ago
|
Attachment #8502793 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in
before you can comment on or make changes to this bug.
Description
•