1080894 - [Loop] MO Ringtone always plays over speaker even wired headset was connected

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Jay]

Pre-Conditions:
1. Insert stereo wired headset 

Steps to reproduce:
1. Launch FirefoxHello app
2. Now start MO VT call from the device

Issue:
Observed MO calling tone is not routing to stereo wired headset

Expected behavior:
MO calling tone should route to stereo wired headset

Typically, the MT ringtone plays out on speaker but the MO calling tone plays over wired headset.

Comment 1

[Jay]

Can Tef help to take a look at this?

Comment 2

[Maria Angeles Oteo (:oteo)]

Sure! including it in the meta so QA team can confirm it

Comment 3

[Maria Angeles Oteo (:oteo)]

Yep, this is pretty bad. When device is going to start a Video Call, any sound is by default sent to the speaker, there are two situations where this can happen:

1 - When the user starts a video call (the one reported in this bug), the ringback tones are sent to the speaker and the conversation audio too.
2 - When the user decides to accept a call as a video call. In this case, the conversation audio is routed to the speaker.

We should add an extra condition that is checking if headsets are available and in that case either in 1/ or 2/ we should send the sound to the headset (not to the speaker)

Comment 4

[Inder]

[Blocking Requested - why for this release]:

Comment 5

[Maria Angeles Oteo (:oteo)]

Hi Inder, this is not a gecko/gaia bug so the blocking-b2g flag does not apply. It needs to be fixed in the Loop mobile aplicación and has already been triaged and prioritized as a blocker bug.

Comment 6

[Carmen Jimenez Cabezas]

Attachment: V1 Proposed patch

Comment 7

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8505010 [details] [review]
V1 Proposed patch

Thanks Carmen, as we commented offline the patch needs some changes. Request review at us when you are done please.

Comment 8

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8505010 [details] [review]
V1 Proposed patch

LGTM, thanks

Comment 9

[Carmen Jimenez Cabezas]

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/d56fe348f37ed3a622a8b78ebe0063903623bd39

Comment 10

[Javier de Prado]

Verified on loop version 1.1: 38eadf0
Flame:flame-KK.user.v2.0.188based.B-66.Gecko-567c7eb.Gaia-ab83632
FireE:firee-kk-v2.0-SW2E5-4 

Tone is routing to stereo wired headset, and when incoming call is receiving, tone is heard on both, speaker and headset, as in GSM calls.