Closed Bug 1080906 Opened 10 years ago Closed 10 years ago

Series signature calculation depends on behaviour of python dictionaries and is not robust

Categories

(Tree Management :: Treeherder, defect)

Product:
Tree Management
Component:
Treeherder
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 1080219

People

(Reporter: wlach, Unassigned)

Details

Here's the current set of code we have for calculating series signatures: https://github.com/mozilla/treeherder-service/blob/master/treeherder/etl/perf_data_adapters.py#L227 It seems like the order of signature properties has been deterministic by some coincidence of the way we're using python, but we should probably sort this stuff to make sure that stays the case. We should probably also include the *name* of the property as well as the property itself in our calculation. We will need to update the old series signatures in the database (and the things that reference them) at the same time as we apply a fix here. This should not be that difficult, but does require a bit of coordination.
This was fixed with bug 1080219
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Resolution: FIXED → DUPLICATE
You need to log in before you can comment on or make changes to this bug.