Closed Bug 1080922 Opened 10 years ago Closed 10 years ago

Conformance mochitests don't report subtest results to the mochitest runner

Categories

(Core :: Graphics: CanvasWebGL, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: jgilbert, Assigned: jgilbert)

References

(Blocks 1 open bug)

Details

Attachments

(4 files, 1 obsolete file)

This makes it harder to identify what failed from Try logs.
Attachment #8502874 - Flags: review?(dglastonbury)
No review for this patch, since it's just regenerating files.
This should make it easier to run just conformance on just non-conformance tests via `mach mochitest-plain dom/canvas/test/webgl-{conformance,mochitests}`.
Attachment #8502878 - Flags: review?(dglastonbury)
Comment on attachment 8502874 [details] [diff] [review]
0001-Add-subtest-logging-to-mochi-single.html.patch

Review of attachment 8502874 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/test/webgl-conformance/mochi-single.html
@@ +180,4 @@
>  
> +  gExpectFailures = false;
> +  if (gTestPath in GetExpectedTestFailSet())
> +    gExpectFailures = true;

gExpectFailures = (gTestPath in GetExpectedTestFailSet()), yeah?
Attachment #8502874 - Flags: review?(dglastonbury) → review+
Attachment #8502878 - Flags: review?(dglastonbury) → review+
Depends on: 763355
(In reply to Dan Glastonbury :djg :kamidphish from comment #5)
> Comment on attachment 8502874 [details] [diff] [review]
> 0001-Add-subtest-logging-to-mochi-single.html.patch
> 
> Review of attachment 8502874 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/canvas/test/webgl-conformance/mochi-single.html
> @@ +180,4 @@
> >  
> > +  gExpectFailures = false;
> > +  if (gTestPath in GetExpectedTestFailSet())
> > +    gExpectFailures = true;
> 
> gExpectFailures = (gTestPath in GetExpectedTestFailSet()), yeah?

I suppose.
r=kamidphish
Attachment #8502874 - Attachment is obsolete: true
Attachment #8502935 - Flags: review+
Comment on attachment 8502933 [details] [diff] [review]
0004-Stop-logging-from-fixed-bug-763355.patch

Review of attachment 8502933 [details] [diff] [review]:
-----------------------------------------------------------------

Did you find out why the failures happen?
Attachment #8502933 - Flags: review?(dglastonbury) → review+
(In reply to Dan Glastonbury :djg :kamidphish from comment #10)
> Comment on attachment 8502933 [details] [diff] [review]
> 0004-Stop-logging-from-fixed-bug-763355.patch
> 
> Review of attachment 8502933 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Did you find out why the failures happen?

Yeah, we clearly call testPassed() after finish() in the logging that patch removed. It seems like the looser coupling we had before allowed this to go undetected.
Blocks: 1081323
Filed bug 1102402 for intermittent issue on test_conformance__canvas__buffer-offscreen-test.html
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.