UITour: Investigate letting the tour page know where Hello panel and room view are positioned

RESOLVED FIXED

Status

()

Firefox
General
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Dolske, Assigned: MattN)

Tracking

unspecified
Points:
3
Bug Flags:
firefox-backlog +
qe-verify -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

4 years ago
Created attachment 8502918 [details]
Early mockup

The Hello tour would like to have indicate where to generally perform actions in the UI. We think this can be be simply, by having these indicators in-content (as opposed to, say, chrome arrowpanels). But we'd like to provide some positioning information to help the indicator bubbles point near the right place.

Matt's suggestion is to have an API that returns the size and position (in pixels) of the Hello panel and room view, and content can then use that to adjust where it's pointing. We don't need to report pixel-precise positions of elements within those views, the bubble can just point to the approximate location.

Exact API TBD.
(Reporter)

Comment 1

4 years ago
So far the tour wants to generally point towards:

  * New Room button
  * Email/Copy Link buttons
  * List of active rooms
  * Sign Up (create account)

Note the panel or view may be animated while opening, so we should be careful to report the final size/position and not some intermediate state.
(Reporter)

Comment 2

4 years ago
Some possible overlap with bug 1080947 -- the "room view opened" notification could include the view's size and position.
Unfocused thinks this may be a problem on Linux so that needs investigation.
Assignee: nobody → MattN+bmo
Status: NEW → ASSIGNED
Iteration: --- → 36.2
Points: --- → 5
Flags: qe-verify-
Flags: firefox-backlog+

Updated

4 years ago
Iteration: 36.2 → 36.3
(Reporter)

Updated

4 years ago
No longer blocks: 1098620
Created attachment 8526869 [details] [diff] [review]
WIP to use regular UITour panels

I'll morph this bug into an investigation bug later and move this patch to a new bug but for now this is a WIP which implements the tour targets with real info panels. It depends on bug 1080943.

I think this way will end up being better overall and I will comment with more details later.

Updated

4 years ago
Iteration: 36.3 → 37.1
Letting the page know about the initial position of panels is possible although handling re-positioning and having the page also deal with RTL will make it slower to develop and will likely lead to more bugs. I have a WIP patch (attachment 8526869 [details] [diff] [review]) that works with the normal UITour panels and it seems like that approach is feasible.
Status: ASSIGNED → RESOLVED
Points: 5 → 3
Last Resolved: 4 years ago
Resolution: --- → FIXED
Summary: UITour: tour page needs to know where Hello panel and room view are positioned → UITour: Investigate letting the tour page know where Hello panel and room view are positioned
Attachment #8526869 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.