Closed
Bug 1080946
Opened 10 years ago
Closed 10 years ago
__asan_poison_memory_region and __asan_unpoison_memory_region should not be dllexport
Categories
(Core :: MFBT, defect)
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
1.14 KB,
patch
|
n.nethercote
:
review+
|
Details | Diff | Splinter Review |
ASAN on Windows now supports -MD, which means that the fix to bug 1036215 needs to be tweaked to not mark these functions as dllexport. Currently, we get: 5:40.89 ../dist/include/mozilla/MemoryChecking.h(44,1) : error(clang): redeclaration of '__asan_poison_memory_region' cannot add 'dllexport' attribute 5:40.89 __asan_poison_memory_region(void const volatile *addr, size_t size); 5:40.89 ^ 5:40.89 c:/moz/fallback/obj-ff-asan/dist/include/nspr\plarena.h(102,6) : note(clang): previous declaration is here 5:40.89 void __asan_poison_memory_region(void const volatile *addr, size_t size); 5:40.89 ^
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8502923 -
Flags: review?(n.nethercote)
Comment 2•10 years ago
|
||
Comment on attachment 8502923 [details] [diff] [review] Don't mark ASAN poisoning functions as dllexport on Windows; r=njn Review of attachment 8502923 [details] [diff] [review]: ----------------------------------------------------------------- r=me if it builds! :)
Attachment #8502923 -
Flags: review?(n.nethercote) → review+
Comment 3•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c32fd9b9c355
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in
before you can comment on or make changes to this bug.
Description
•