Closed Bug 1080994 Opened 5 years ago Closed 5 years ago

Build libclearkey without a dependency on mozalloc or mozglue

Categories

(Core :: Audio/Video, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

Tell me if I'm wrong, but I don't see a compelling reason for libclearkey to depend on either mozalloc or mozglue. I doubt other gmp plugins would depend on them. The one fishy thing resulting from this is that its memory allocations wouldn't go through jemalloc on windows, but so would those from 3rd party gmp plugins, which brings up the case of changing how we hook memory allocation, but that would be a separate bug.
> its memory allocations wouldn't go through jemalloc on windows

well, it doesn't look like it's doing any allocation of its own...
dkeeler for ScopedNSSTypes.h.
cpearce for the dependency change itself.
Attachment #8502983 - Flags: review?(dkeeler)
Attachment #8502983 - Flags: review?(cpearce)
Comment on attachment 8502983 [details] [diff] [review]
Build libclearkey without a dependency on mozalloc or mozglue

Review of attachment 8502983 [details] [diff] [review]:
-----------------------------------------------------------------

r=me for PSM changes.

::: security/manager/ssl/src/ScopedNSSTypes.h
@@ +263,2 @@
>      mozalloc_handle_oom(len);
> +    if (MOZ_UNLIKELY(!SECITEM_AllocItem(nullptr, &item, len)))

Honestly, I'm not entirely sure why we have this. We may be able to get rid of this wrapper entirely, but until someone takes the effort to figure that out, this is fine.
Attachment #8502983 - Flags: review?(dkeeler) → review+
Attachment #8502983 - Flags: review?(cpearce) → review+
https://hg.mozilla.org/mozilla-central/rev/c0df45ff2944
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.