Closed
Bug 1081029
Opened 10 years ago
Closed 10 years ago
Standalone link clicker call state in the page title (tab name)
Categories
(Hello (Loop) :: Client, defect)
Hello (Loop)
Client
Tracking
(firefox36 verified)
Tracking | Status | |
---|---|---|
firefox36 | --- | verified |
People
(Reporter: RT, Assigned: jaws)
References
Details
Attachments
(1 file)
9.42 KB,
patch
|
dmosedale
:
review+
|
Details | Diff | Splinter Review |
Bug 1070753 dealt with changing the title name from "Loop" to "Firefox Hello" This bug is about adding real-time information about the call status in the status per the format "Firefox Hello - <status>" The different values for <status> are: * "Connecting" - per current "Connecting" notification * "Ringing" - per current "Ringing" notification * "In conversation" - for as long as the conversation is connected * "Conversation ended" - when the conversation ends and the feedback form is being displayed * "Something went wrong" - when the conversation fails to connect nothing gets displayed in the call status when the user is on the initial landing screen.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Iteration: --- → 35.3
Points: --- → 2
Assignee | ||
Comment 1•10 years ago
|
||
Dan, can you test this patch with a local call? I can't get call URLs to generate with my local server (POST http://localhost:3000/registration [HTTP/1.1 404 Not Found 1ms]). All of the standalone and shared UI tests pass with it though.
Attachment #8503346 -
Flags: review?(dmose)
Assignee | ||
Updated•10 years ago
|
Flags: in-testsuite-
Flags: firefox-backlog+
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8503346 [details] [diff] [review] Patch Review of attachment 8503346 [details] [diff] [review]: ----------------------------------------------------------------- Gijs said in person he gives r+ for the string changes.
Attachment #8503346 -
Flags: review?(standard8)
Comment 3•10 years ago
|
||
Comment on attachment 8503346 [details] [diff] [review] Patch Review of attachment 8503346 [details] [diff] [review]: ----------------------------------------------------------------- Looks good; I just tested it and things are working nicely. r=dmose
Attachment #8503346 -
Flags: review?(standard8)
Attachment #8503346 -
Flags: review?(dmose)
Attachment #8503346 -
Flags: review+
Assignee | ||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/2939a2996f46
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/2939a2996f46
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: mozilla35 → mozilla36
Paul, please test this in tomorrow's Nightly.
Flags: needinfo?(paul.silaghi)
QA Contact: anthony.s.hughes → paul.silaghi
Comment 7•10 years ago
|
||
Verified fixed 36.0a1 (2014-10-19) using the dev-server on Win 7, Ubuntu 14.04, OS X 10.9.5.
You need to log in
before you can comment on or make changes to this bug.
Description
•