Closed Bug 1081029 Opened 10 years ago Closed 10 years ago

Standalone link clicker call state in the page title (tab name)

Categories

(Hello (Loop) :: Client, defect)

defect
Not set
normal
Points:
2

Tracking

(firefox36 verified)

VERIFIED FIXED
mozilla36
Iteration:
35.3
Tracking Status
firefox36 --- verified

People

(Reporter: RT, Assigned: jaws)

References

Details

Attachments

(1 file)

Bug 1070753 dealt with changing the title name from "Loop" to "Firefox Hello"
This bug is about adding real-time information about the call status in the status per the format "Firefox Hello - <status>"

The different values for <status> are:
* "Connecting" - per current "Connecting" notification
* "Ringing" - per current "Ringing" notification
* "In conversation" - for as long as the conversation is connected
* "Conversation ended" - when the conversation ends and the feedback form is being displayed
* "Something went wrong" - when the conversation fails to connect
nothing gets displayed in the call status when the user is on the initial landing screen.
No longer depends on: 1070753
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Iteration: --- → 35.3
Points: --- → 2
Flags: qe-verify+
Attached patch PatchSplinter Review
Dan, can you test this patch with a local call? I can't get call URLs to generate with my local server (POST http://localhost:3000/registration [HTTP/1.1 404 Not Found 1ms]).

All of the standalone and shared UI tests pass with it though.
Attachment #8503346 - Flags: review?(dmose)
Flags: in-testsuite-
Flags: firefox-backlog+
Comment on attachment 8503346 [details] [diff] [review]
Patch

Review of attachment 8503346 [details] [diff] [review]:
-----------------------------------------------------------------

Gijs said in person he gives r+ for the string changes.
Attachment #8503346 - Flags: review?(standard8)
Comment on attachment 8503346 [details] [diff] [review]
Patch

Review of attachment 8503346 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good; I just tested it and things are working nicely.

r=dmose
Attachment #8503346 - Flags: review?(standard8)
Attachment #8503346 - Flags: review?(dmose)
Attachment #8503346 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/2939a2996f46
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: mozilla35 → mozilla36
Paul, please test this in tomorrow's Nightly.
Flags: needinfo?(paul.silaghi)
QA Contact: anthony.s.hughes → paul.silaghi
Verified fixed 36.0a1 (2014-10-19) using the dev-server on Win 7, Ubuntu 14.04, OS X 10.9.5.
Status: RESOLVED → VERIFIED
Flags: needinfo?(paul.silaghi)
You need to log in before you can comment on or make changes to this bug.